Skip to content

fix(loadable-components): skip transformation when ssr: false is specified #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kdy1 merged 1 commit into from
Mar 21, 2026
Merged

fix(loadable-components): skip transformation when ssr: false is specified #592

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions packages/loadable-components/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,43 @@ where
false
}

fn has_ssr_false(&self, call: &CallExpr) -> bool {
let options = match call.args.get(1) {
Some(arg) => &arg.expr,
None => return false,
};

let obj = match options.as_ref() {
Expr::Object(obj) => obj,
_ => return false,
};

obj.props.iter().any(|prop| match prop {
PropOrSpread::Prop(prop) => match prop.as_ref() {
Prop::KeyValue(kv) => {
let is_ssr_key = match &kv.key {
PropName::Ident(i) => &*i.sym == "ssr",
Comment on lines +141 to +145

@chatgpt-codex-connector chatgpt-codex-connector Bot Mar 21, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Respect later overrides when checking ssr: false

has_ssr_false() now returns true if any property in the options object is ssr: false, but JavaScript object literals are order-sensitive. Inputs like loadable(() => import('./Comp'), { ssr: false, ...opts }) or { ssr: false, ssr: true } end up with ssr !== false at runtime, yet this branch still skips the transform entirely. In those cases we silently drop the loadable SSR metadata even though SSR is effectively enabled.

Useful? React with 👍 / 👎.

PropName::Str(s) => s.value == "ssr",
_ => false,
};
is_ssr_key
&& matches!(
kv.value.as_ref(),
Expr::Lit(Lit::Bool(Bool { value: false, .. }))
)
}
_ => false,
},
_ => false,
})
}

fn transform_import_expr(&mut self, call: &mut CallExpr) {
// Skip transformation if ssr: false is specified in the options
if self.has_ssr_false(call) {
return;
}

let import = {
let mut v = ImportFinder::default();
call.visit_with(&mut v);
Expand Down
2 changes: 2 additions & 0 deletions ...le-components/tests/fixture/simple import/should not transform when ssr is false/input.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
import loadable from "@loadable/component";
loadable(() => import("./OtherComponent"), { ssr: false });
4 changes: 4 additions & 0 deletions ...e-components/tests/fixture/simple import/should not transform when ssr is false/output.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
import loadable from "@loadable/component";
loadable(()=>import("./OtherComponent"), {
ssr: false
});
Loading