Skip to content

build: Update swc_core to v60.0.0#605

Merged
kdy1 merged 3 commits into
mainfrom
kdy1/core
Mar 30, 2026
Merged

build: Update swc_core to v60.0.0#605
kdy1 merged 3 commits into
mainfrom
kdy1/core

Conversation

@kdy1
Copy link
Copy Markdown
Member

@kdy1 kdy1 commented Mar 30, 2026

No description provided.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 30, 2026

⚠️ No Changeset found

Latest commit: 3d3d20c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kdy1 kdy1 enabled auto-merge (squash) March 30, 2026 15:02
@claude
Copy link
Copy Markdown

claude Bot commented Mar 30, 2026

PR Review: build: Update swc_core to v60.0.0

This is a routine dependency update + version normalization PR. The changes look clean and well-structured overall. A few observations:

Observations

Version normalization to 1.0.0 — Many crates (emotion, prefresh, relay, styled-components, styled-jsx, remove-console, react-remove-properties, transform-imports, swc-confidential, swc-magic, swc-sdk, etc.) are being promoted from pre-1.0 versions (e.g. 0.116.0, 0.86.0) to 1.0.0. This is a significant milestone signaling API stability for these crates.

Script change (scripts/update-swc-core.sh) — The flag change from --breaking to --level major aligns with this strategy of doing major bumps on each swc_core update. Makes sense given ABI compatibility requirements.

Explicit version constraints on path deps — Adding version = "1.0.0" to local path dependencies (e.g. swc_emotion = { path = "./transform", version = "1.0.0" }) is good practice for crates.io publishing, ensuring the published crate resolves the correct version.

Minor Nits

TOML spacing — The added version fields use { path = "./transform" , version = "1.0.0" } (space before comma). This is valid TOML but inconsistent with the rest of the file style which typically places the comma immediately after the value. Consider { path = "./transform", version = "1.0.0" } for consistency.

Outer wrapper crates not bumped — The outer plugin wrapper crates for react-remove-properties (0.19.4), remove-console, and transform-imports (0.19.4) weren't version-bumped in their own Cargo.toml even though their transform sub-crates jumped to 1.0.0. If these outer wrappers are published to crates.io separately, a version bump may be warranted to reflect the breaking sub-dependency change.

Summary

The core changes (Cargo.lock updates, swc_core 59→60, swc_ecma_minifier 47→48, swc_ecma_usage_analyzer 30→31) are correct and consistent. The changeset-bot warning about missing changesets would be worth addressing if npm package releases are expected from this PR.

Overall this looks good to merge. The nits are minor and the automated nature of the update (via the bump script) is appropriate for this type of maintenance PR.

@kdy1 kdy1 merged commit 838066f into main Mar 30, 2026
11 checks passed
@kdy1 kdy1 deleted the kdy1/core branch March 30, 2026 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant