You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
This is a routine dependency update + version normalization PR. The changes look clean and well-structured overall. A few observations:
Observations
Version normalization to 1.0.0 — Many crates (emotion, prefresh, relay, styled-components, styled-jsx, remove-console, react-remove-properties, transform-imports, swc-confidential, swc-magic, swc-sdk, etc.) are being promoted from pre-1.0 versions (e.g. 0.116.0, 0.86.0) to 1.0.0. This is a significant milestone signaling API stability for these crates.
Script change (scripts/update-swc-core.sh) — The flag change from --breaking to --level major aligns with this strategy of doing major bumps on each swc_core update. Makes sense given ABI compatibility requirements.
Explicit version constraints on path deps — Adding version = "1.0.0" to local path dependencies (e.g. swc_emotion = { path = "./transform", version = "1.0.0" }) is good practice for crates.io publishing, ensuring the published crate resolves the correct version.
Minor Nits
TOML spacing — The added version fields use { path = "./transform" , version = "1.0.0" } (space before comma). This is valid TOML but inconsistent with the rest of the file style which typically places the comma immediately after the value. Consider { path = "./transform", version = "1.0.0" } for consistency.
Outer wrapper crates not bumped — The outer plugin wrapper crates for react-remove-properties (0.19.4), remove-console, and transform-imports (0.19.4) weren't version-bumped in their own Cargo.toml even though their transform sub-crates jumped to 1.0.0. If these outer wrappers are published to crates.io separately, a version bump may be warranted to reflect the breaking sub-dependency change.
Summary
The core changes (Cargo.lock updates, swc_core 59→60, swc_ecma_minifier 47→48, swc_ecma_usage_analyzer 30→31) are correct and consistent. The changeset-bot warning about missing changesets would be worth addressing if npm package releases are expected from this PR.
Overall this looks good to merge. The nits are minor and the automated nature of the update (via the bump script) is appropriate for this type of maintenance PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.