Revert to getopts for argument parsing#169
Conversation
Codecov Report
@@ Coverage Diff @@
## master #169 +/- ##
============================================
- Coverage 100.00% 83.83% -16.17%
============================================
Files 4 4
Lines 142 167 +25
============================================
- Hits 142 140 -2
- Misses 0 27 +27
Continue to review full report at Codecov.
|
|
Haven't really had a chance to go through this yet, but in case it's helpful you can take a look at what we had prior to the original switch from getopts to clap in https://github.com/swellaby/rusty-hook/blob/39fbca3b90c6f37bfdacd23bc4d25b9a0da554f0/src/main.rs The only potential user interaction with the executable is |
|
Apologies, I thought CI was failing outright here, but see it's coverage related. That's a somewhat surprising drop, do you think it's legitimate based on the diff or a specious tarpaulin and/or codecov issue? |
Changes
Related Issues
I'd like to get some input on the trajectory of my work to revert back to getopts, so I can hopefully get it to an acceptable state in the next couple of days. Please let me know if there's any concerns or comments about the work so far 🙂
I'm not entirely happy with the changes yet, as I think the
main()function has become a bit too complex. There's also a.to_stringcall in thecreate_hook_filesthat I'd like to get rid of.