Conversation
gjcairo
force-pushed
the
bootstrap-fixes
branch
from
0658298 to
cb6bca2
Compare
FranzBusch
reviewed
Aug 28, 2025
| } | ||
| } catch { | ||
| logger.debug("Error thrown while handling connection") | ||
| logger.debug("Error thrown while handling connection: \(error)") |
Contributor
There was a problem hiding this comment.
We need to revisit the logs to not interpolate in the future
Collaborator
Author
There was a problem hiding this comment.
Ah, I can open a PR to do this - should we include the error as metadata instead?
FranzBusch
approved these changes
Aug 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current bootstrapping of the HTTP pipeline isn't fully correct. We're currently always setting up the pipeline using secure upgrade. This means that we need to wait for the SSL handshake to conclude to finish negotiating the protocol we're using. However, if we are setting up an insecure channel (i.e. without TLS) we never add a TLS handler to the pipeline, causing the protocol negotiation handler to wait forever for the handshake to finish. This means that insecure H1 requests currently don't work.
This PR changes this to set up the pipeline for H1 if TLS is not being used. We could consider adding h2c support.