Enable Swift 6.3 jobs in CI#75
Merged
rnro merged 1 commit intoswift-server:mainfrom Apr 1, 2026
Merged
Conversation
Motivation: Swift 6.3 has been released, we should add it to our CI coverage. Modifications: Add additional Swift 6.3 jobs where appropriate in main.yml, pull_request.yml Result: Improved test coverage.
aryan-25
approved these changes
Apr 1, 2026
gjcairo
reviewed
Apr 1, 2026
| # linux_6_1_arguments_override: "-Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable" | ||
| linux_6_2_enabled: false | ||
| # linux_6_2_arguments_override: "-Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable" | ||
| linux_6_3_enabled: false |
Collaborator
There was a problem hiding this comment.
This should be enabled now, this builds fine on 6.3
| linux_6_2_enabled: false | ||
| # linux_6_2_arguments_override: "-Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable" | ||
| linux_6_3_enabled: false | ||
| # linux_6_2_arguments_override: "-Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable" |
Collaborator
There was a problem hiding this comment.
This shouldn't have been copied: it should be for 6.3 and be uncommented.
| @@ -20,6 +20,8 @@ jobs: | |||
| # linux_6_1_arguments_override: "-Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable" | |||
| linux_6_2_enabled: false | |||
Collaborator
There was a problem hiding this comment.
I know this isn't from this PR but we should probably enable this too when fixing the 6.3 stuff.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Swift 6.3 has been released, we should add it to our CI coverage.
Modifications:
Add additional Swift 6.3 jobs where appropriate in main.yml, pull_request.yml
Result:
Improved test coverage.