Retry installing Visual Studio Build Tools on failure#177
Closed
plemarquand wants to merge 4 commits intoswiftlang:mainfrom
Closed
Retry installing Visual Studio Build Tools on failure#177plemarquand wants to merge 4 commits intoswiftlang:mainfrom
plemarquand wants to merge 4 commits intoswiftlang:mainfrom
Conversation
bkhouri
reviewed
Nov 3, 2025
Contributor
bkhouri
left a comment
bkhouri
left a comment
There was a problem hiding this comment.
Some comments for your consideration.
bkhouri
reviewed
Nov 3, 2025
plemarquand
force-pushed
the
install-vsb-retries
branch
2 times, most recently
from
7deb288 to
6e1cdb2
Compare
We've seen occasional failures to install the Visual Studio Build Tools due to flakey responses from the server. Attempt to make this script more robust by adding a retry with exponential backoff, attempting up to 10 times before eventually giving up. This adds the same logic to both the VSB and Swift toolchain downloads.
plemarquand
force-pushed
the
install-vsb-retries
branch
from
6e1cdb2 to
79b5dd5
Compare
award999
reviewed
Nov 12, 2025
Contributor
|
Is there any advantage to using Invoke-WebRequest versus just using curl with --retry? Windows has it built-in nowadays. The code would be a lot simpler. |
plemarquand
force-pushed
the
install-vsb-retries
branch
from
a574176 to
faf7a9d
Compare
plemarquand
force-pushed
the
install-vsb-retries
branch
from
faf7a9d to
d2e883d
Compare
Contributor
Author
|
@jakepetroules that does simplify things; I've updated the PR. |
Contributor
Author
|
@shahmishal could you take a look at this PR? Hopefully it will mitigate CI failures like this one: https://github.com/swiftlang/vscode-swift/actions/runs/19445040869/job/55637697861 |
jakepetroules
approved these changes
Nov 19, 2025
Contributor
|
Is this superseded by #199? |
Contributor
Author
|
@jakepetroules looks like it is. I've added a review comment there and once its merged I'll close this PR |
Contributor
Author
|
Closed in favour of #199 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've seen occasional failures to install the Visual Studio Build Tools due to flakey responses from the server.
Attempt to make this script more robust by adding a retry with exponential backoff, attempting up to 10 times before eventually giving up. This adds the same logic to both the VSB and Swift toolchain downloads.