Always use the current version of the scripts (soundness checks)#180
Conversation
This applies the changes previously made swift_package_test to the soundness checks.
ahoppen
left a comment
ahoppen
left a comment
There was a problem hiding this comment.
Would it make sense to extract these steps to checkout the github-workflows repository to a reusable workflow?
| run: | | ||
| which curl yq || (apt -q update && apt -yq install curl yq) | ||
| curl -s --retry 3 https://raw.githubusercontent.com/swiftlang/github-workflows/refs/heads/main/.github/workflows/scripts/check-docs.sh | bash | ||
| cat ${{ steps.script_path.outputs.root }}/.github/workflows/scripts/check-docs.sh | bash |
There was a problem hiding this comment.
Can’t this just be
| cat ${{ steps.script_path.outputs.root }}/.github/workflows/scripts/check-docs.sh | bash | |
| bash ${{ steps.script_path.outputs.root }}/.github/workflows/scripts/check-docs.sh |
Same for the other cases where you pipe to bash.
There was a problem hiding this comment.
Maybe, but I'm following the pattern set by the first PR. After it's all landed we could explore refactoring it further. I just want to get it working first.
There was a problem hiding this comment.
OK, good with me, same for trying to share steps using a reusable workflow.
I'd like to get it all landed first, then explore refactoring afterwards. |
|
Failures are just network flakiness. |
4 participants
This applies the changes previously made swift_package_test to the soundness checks.