Change default Android SDK build command#269
Conversation
jakepetroules
force-pushed
the
patch-1
branch
4 times, most recently
from
fb98750 to
11f9ecf
Compare
|
I think the fix in swift-android-sdk#3 should resolve the |
|
Thanks, I incorporated your changes. |
|
It looks like it is still failing, but the new log message indicates that it is using the right host toolchain: That new failure seems to be coming from: Should we be expecting a different output folder? |
jakepetroules
force-pushed
the
patch-1
branch
2 times, most recently
from
89ee068 to
26548d7
Compare
|
I think the issue here is that So for example, we need to change the assumption that the test case is built at |
jakepetroules
force-pushed
the
patch-1
branch
12 times, most recently
from
6eb6d0c to
21be017
Compare
jakepetroules
force-pushed
the
patch-1
branch
4 times, most recently
from
4ffd4c5 to
5742b2a
Compare
| description: "Command to use when building the package with the Swift SDK for Android" | ||
| # Temporarily use native build system on Android due to https://github.com/swiftlang/swift/issues/88282 | ||
| default: "swift build --build-system native" | ||
| default: "swift build" |
- Change default build command to use 'swift build' instead of 'swift build --build-system native' (the 4/27 snapshot contains the requisite changes for Android) - Use the correct host toolchain for Android build/test - Add mention of the specific host SDK being used to build For Wasm, we want to wait until swiftlang/swift-build#1348 lands before unpinning. Co-authored-by: Marc Prud'hommeaux <mwp1@cornell.edu>
…g swift-build in SwiftPM (#1745) @marcprux found that [the trunk snapshot toolchain now successfully cross-compiles the tests for Android](swiftlang/swift-package-manager#8094 (comment)), which I was able to reproduce locally with the latest 6.4 snapshot also. With the latest GitHub workflows using `swift-build` again for the 6.4 and trunk snapshots, swiftlang/github-workflows#269, let's see if the trunk tests run in the emulator. We currently cross-compile this repo to Android using the defaults of 6.3, nightly-6.3, and trunk, and we'll probably add nightly-6.4 soon: can we drop cross-compiling for Android with 6.3 then? That will allow us to run the tests for 6.4 and trunk in the emulator, without any workarounds needed for 6.3 being unable to cross-compile these tests. Co-authored-by: Jonathan Grynspan <jgrynspan@apple.com>
4 participants
Updated default build command for Android SDK to use 'swift build' instead of 'swift build --build-system native'.
The 4/27 snapshot contains the requisite changes for Android to work.
For Wasm, we want to wait until swiftlang/swift-build#1348 lands before unpinning.