Dealing with multiple swift files : hello.swift and world.swift#11
Open
afabri wants to merge 4 commits into
Open
Dealing with multiple swift files : hello.swift and world.swift#11afabri wants to merge 4 commits into
afabri wants to merge 4 commits into
Conversation
Author
|
Adding a swift file to |
lrineau
reviewed
Apr 26, 2024
lrineau
reviewed
Apr 27, 2024
lrineau
reviewed
Apr 27, 2024
lrineau
reviewed
Apr 27, 2024
lrineau
left a comment
There was a problem hiding this comment.
I have tested locally on Linux. Looks good to me, once the two typos are fixed (missing ! and extra trailing ).
I have reservations: I wonder if it would makes sense to have a extra sub-directory, like:
1_single_executable/
1_bis_single_executable_multiple_swift_files/
Co-authored-by: Laurent Rineau <Laurent.Rineau@cgal.org>
Co-authored-by: Laurent Rineau <Laurent.Rineau@cgal.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using more than one swift file to build the executable hello., one of them must be called
main.swift.It might make sense to. have that as a seprarate example, or just telling it in the readme.