Amend limited interop mode: #expect failure is always stays a failure#3250
Draft
jerryjrchen wants to merge 1 commit intoswiftlang:mainfrom
Draft
Amend limited interop mode: #expect failure is always stays a failure#3250jerryjrchen wants to merge 1 commit intoswiftlang:mainfrom
jerryjrchen wants to merge 1 commit intoswiftlang:mainfrom
Conversation
Increase severity of #expect in XCTest tests for limited interop mode.
For example:
func testLimitedInterop() {
// Before: Warning "Interop failure"
// After: Error "Interop failure"
Issue.record("interop failure")
}
This change is motivated by the real-world challenges during migration
to Swift Testing under the originally accepted proposal. This "limited"
amendment (pun intended?) better addresses those needs!
Before: This had the unfortunate side effect that if you did as
suggested in the proposal and switched from XCTFail() -> Issue.record(),
interop effectively degraded your assertion errors to warnings.
After: you can migrate your XCTest API usage to Swift Testing and
maintain the error severity of your asserts. This effectively makes it
so that Swift Testing API functions "as expected" on ALL interop modes
except for none.
jerryjrchen
added
evolution process
github-project-automation
Bot
moved this to Backlog
in [Swift Testing] Interoperability
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increase severity of #expect in XCTest tests for limited interop mode. For example:
This change is motivated by the real-world challenges during migration to Swift Testing under the originally accepted proposal. This "limited" amendment (pun intended?) better addresses those needs!
Before: This had the unfortunate side effect that if you did as suggested in the proposal and switched from XCTFail() -> Issue.record(), interop effectively degraded your assertion errors to warnings.
After: you can migrate your XCTest API usage to Swift Testing and maintain the error severity of your asserts. This effectively makes it so that Swift Testing API functions "as expected" on ALL interop modes except for none.