Update SE-0337 to reflect @preconcurrency working on decls in Swift 6#3264
Draft
a-viv-a wants to merge 1 commit intoswiftlang:mainfrom
Draft
Update SE-0337 to reflect @preconcurrency working on decls in Swift 6#3264a-viv-a wants to merge 1 commit intoswiftlang:mainfrom
a-viv-a wants to merge 1 commit intoswiftlang:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prompted by bringing up swiftlang/swift#88637, my understanding is that the intention is for
@preconcurrencyto apply to declarations and downgrade errors in Swift 6 the same way it did in Swift 5. In most cases, this is already the way preconcurrency is implemented in the compiler, and cases where it doesn't is a bug and an issue for incremental adoption, since Swift 6 consumers of your types would receive errors, even if you use@preconcurrency. SE-0337 currently doesn't reflect this intention or implementation reality, which is confusing when trying to understand this feature.We should update SE-0337 to be explicit about
@preconcurrencyworking (in ways other than@preconcurrency import) in Swift 6.