Rework ImportsXCTestVisitor class#1244
Draft
bkhouri wants to merge 1 commit into
Draft
Conversation
bkhouri
force-pushed
the
t/main/gh1243_update_neverusefortry_to_support_all_test_library
branch
from
5c4e4f3 to
6cde7e3
Compare
bkhouri
changed the title
ImportsXCTestVisitor class
Contributor
Author
|
The API breakage check build failed with the following These are expected as those have been deprecated and replaced with another. how do we address this? |
The `ImportsXCTestVisitor` class was too restrictive. Rename the class to `ImportsAnyTestingLibrary` and have the visitor class support both XCTest and/or Swift Testing library. The list of "supported" testing modules are store in a property, which can be augmented in the future. Closes swiftlang#1243
bkhouri
force-pushed
the
t/main/gh1243_update_neverusefortry_to_support_all_test_library
branch
from
6cde7e3 to
7d7d3ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ImportsXCTestVisitorclass was too restrictive. Rename the class toImportsAnyTestingLibraryand have the visitor class support both XCTest and/or Swift Testing library.The list of "supported" testing modules are store in a property, which can be augmented in the future.
Closes #1243