[JExtract] Move 'apiKind' property to 'ImportedFunc'#251
Merged
ktoso merged 1 commit intoswiftlang:mainfrom Jun 6, 2025
Merged
[JExtract] Move 'apiKind' property to 'ImportedFunc'#251ktoso merged 1 commit intoswiftlang:mainfrom
ktoso merged 1 commit intoswiftlang:mainfrom
Conversation
rintaro
force-pushed
the
jextract-importeddecl-apikind
branch
from
cd87411 to
a6b18d8
Compare
rintaro
changed the title
rintaro
force-pushed
the
jextract-importeddecl-apikind
branch
2 times, most recently
from
4b575e7 to
07e507f
Compare
It was weird "the lowered signature" being the owner of the API kind information, and it was only used for rendering. Move it to `ImportedFunc` and pass it to `LoweredFunctionSignature.cdeclThunk()` API.
rintaro
force-pushed
the
jextract-importeddecl-apikind
branch
from
07e507f to
72bf28f
Compare
ktoso
approved these changes
Jun 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was weird "the lowered signature" being the owner of the API kind information, and it was only used for rendering.
Move it to
ImportedFuncand pass it toLoweredFunctionSignature.cdeclThunk()API.