Narrow down java.library.path to prevent loading stale dylibs#673
Merged
ktoso merged 2 commits intoswiftlang:mainfrom Apr 6, 2026
Merged
Narrow down java.library.path to prevent loading stale dylibs#673ktoso merged 2 commits intoswiftlang:mainfrom
java.library.path to prevent loading stale dylibs#673ktoso merged 2 commits intoswiftlang:mainfrom
Conversation
ktoso
reviewed
Apr 6, 2026
| "--enable-native-access=ALL-UNNAMED", | ||
| // Include the library paths where our dylibs are that we want to load and call | ||
| "-Djava.library.path=" + (javaLibraryPaths(rootDir) + javaLibraryPaths(project.projectDir)).joinToString(":"), | ||
| "-Djava.library.path=" + javaLibraryPaths(project.projectDir).joinToString(":"), |
Collaborator
There was a problem hiding this comment.
Let's cleanup the : while we're here and use File.pathSeparator?
Suggested change
| "-Djava.library.path=" + javaLibraryPaths(project.projectDir).joinToString(":"), | |
| "-Djava.library.path=" + javaLibraryPaths(project.projectDir).joinToString(File.pathSeparator), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
java.library.pathis currently too broad, causing the sample app to load a stalelibSwiftJava.dylibfrom the repository root's.builddirectory instead of the latest local build.This made testing changes extremely confusing and difficult to debug.
Narrowed the search path to prevent unintended binary shadowing and ensure the app consistently loads the correct, newly built library.