Add type name to macro-generated function names#674
Merged
ktoso merged 1 commit intoswiftlang:mainfrom Apr 6, 2026
Merged
Conversation
Collaborator
|
Lgtm thanks! Nightly ci is broken right now, this is not on us |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Functions generated by the
@JavaImplementationmacro currently usecontext.makeUniqueName.While this ensures uniqueness within the local macro expansion context, it is not globally unique.
As a result, using the same function name across multiple classes leads to symbol collisions.
This PR adds the class name as a prefix to the generated function names to ensure global uniqueness.