Skip to content

generator: Use Swift 6.2.1 by default#246

Merged
MaxDesiatov merged 3 commits into
swiftlang:mainfrom
euanh:swift-6.2
Nov 10, 2025
Merged

generator: Use Swift 6.2.1 by default#246
MaxDesiatov merged 3 commits into
swiftlang:mainfrom
euanh:swift-6.2

Conversation

@euanh
Copy link
Copy Markdown
Contributor

@euanh euanh commented Sep 25, 2025

No description provided.

@euanh euanh requested a review from MaxDesiatov as a code owner September 25, 2025 13:27
@euanh
Copy link
Copy Markdown
Contributor Author

euanh commented Sep 25, 2025

@swift-ci test

@xtremekforever
Copy link
Copy Markdown
Contributor

Easy enough, however do you want to add 6.2 to the E2E matrix?

@MaxDesiatov
Copy link
Copy Markdown
Contributor

I concur, this deserves to include an addition to Tests/SwiftSDKGeneratorTests/EndToEndTests.swift

@Joannis
Copy link
Copy Markdown
Member

Joannis commented Nov 5, 2025

@euanh did you see the above comments?

@euanh
Copy link
Copy Markdown
Contributor Author

euanh commented Nov 5, 2025

@swift-ci test

@euanh
Copy link
Copy Markdown
Contributor Author

euanh commented Nov 5, 2025

@swift-ci test

@euanh
Copy link
Copy Markdown
Contributor Author

euanh commented Nov 6, 2025

Thanks @Joannis

@MaxDesiatov I've updated the tests. There's a lot of duplication now and we should try to reduce it.

  • In Bump swift-tools-version to 6.0 #237 you mentioned that we're no longer directly testing 5.9 and 5.10: shall we drop the end to end tests for those versions as well?
  • If we merge Bump swift-tools-version to 6.0 #237, we should translate the end to end tests to swift-testing parameterised tests.
    I'd prefer to merge this PR as-is and make those changes in their own PRs.

Comment thread Sources/GeneratorCLI/GeneratorCLI.swift Outdated

@Option(help: "Version of Swift to supply in the bundle.")
var swiftVersion = "6.1.2-RELEASE"
var swiftVersion = "6.2-RELEASE"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks! Just one suggestion here, maybe we should update it to use 6.2.1 now that's out?

@euanh
Copy link
Copy Markdown
Contributor Author

euanh commented Nov 10, 2025

@swift-ci test

@euanh euanh changed the title generator: Use Swift 6.2 by default generator: Use Swift 6.2.1 by default Nov 10, 2025
@MaxDesiatov MaxDesiatov merged commit 01e610b into swiftlang:main Nov 10, 2025
41 checks passed
@euanh euanh deleted the swift-6.2 branch November 11, 2025 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants