Adopt executable path API (sorta) from the stdlib.#1801
Open
grynspan wants to merge 1 commit into
Open
Conversation
swiftlang/swift#90476 added an exported function to the stdlib on non-Apple platforms to get the current executable's path. We should adopt this implementation instead of continuing to use our own. On Apple platforms, due to back-deployment requirements, that function is not implemented and we instead continue to call `_NSGetExecutablePath()`. I have cherry-picked the change to 6.4.x [here](swiftlang/swift#90659), so the change should work there too once the toolchain builds a new nightly.
grynspan
added
attachments/activities
| static var executablePath: String { | ||
| get throws { | ||
| #if SWT_TARGET_OS_APPLE | ||
| #if hasFeature(Embedded) || os(WASI) |
Contributor
There was a problem hiding this comment.
Should this be its own configuration?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
swiftlang/swift#90476 added an exported function to the stdlib on non-Apple platforms to get the current executable's path. We should adopt this implementation instead of continuing to use our own.
On Apple platforms, due to back-deployment requirements, that function is not implemented and we instead continue to call
_NSGetExecutablePath().I have cherry-picked the change to 6.4.x here, so the change should work there too once the toolchain builds a new nightly.
Checklist: