🍒 [6.4] Remove underscore from iteration in JSON record for encoded events#1802
Merged
harlanhaskins merged 1 commit intoJul 18, 2026
Merged
Conversation
…1792) I missed this in the implementation of ST-0024, `iteration` on the encoded event needs to be non-underscored. Fixes rdar://182236523 Implements the ST-0024 spec. Just removes the underscore and adds a regression test. - [x] Code and documentation should follow the style of the [Style Guide](https://github.com/apple/swift-testing/blob/main/Documentation/StyleGuide.md). - [x] If public symbols are renamed or modified, DocC references should be updated.
harlanhaskins
requested review from
briancroom,
grynspan,
jerryjrchen and
stmontgomery
as code owners
July 17, 2026 22:26
stmontgomery
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This exposes the
iterationfield, per ST-0024Scope:
Exposes already-approved public API to the JSON schema.
Issues:
rdar://182236523
Original PRs:
Remove underscore from
iterationin JSON record for encoded events #1792Risk:
Low
Testing:
Ran existing unit tests in CI and locally.
Reviewers:
@stmontgomery @grynspan