Fix .testStarted etc. events being suppressed for suites.#1804
Merged
Conversation
This fixes events in the JSON event stream not being emitted for test suites. The logic for detecting non-parameterized test (function)s is incorrect and does not account for them. Caused by #1793.
grynspan
requested review from
briancroom,
harlanhaskins,
jerryjrchen and
stmontgomery
as code owners
July 20, 2026 18:18
grynspan
added
bug
stmontgomery
approved these changes
Jul 20, 2026
grynspan
added a commit
that referenced
this pull request
Jul 20, 2026
…1805) - **Explanation**: Fixes a regression in the JSON event stream that causes suite events to be suppressed. - **Scope**: JSON event stream, interop - **Issues**: N/A - **Original PRs**: #1804 - **Risk**: Low - **Testing**: New unit test added. - **Reviewers**: @stmontgomery @harlanhaskins
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes events in the JSON event stream not being emitted for test suites. The logic for detecting non-parameterized test (function)s is incorrect and does not account for them.
Caused by #1793.
Checklist: