Skip to content

[6.4.x] Fix .testStarted etc. events being suppressed for suites. #1805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
grynspan merged 1 commit into from
Jul 20, 2026
Merged

[6.4.x] Fix .testStarted etc. events being suppressed for suites. #1805

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions Sources/Testing/ABI/Encoded/ABI.EncodedEvent.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,35 +67,38 @@ extension ABI {
/// `testStarted`/`testEnded` events, and replace `testCaseStarted`/
/// `testCaseEnded` with `testStarted`/`testEnded`.
/// - For parameterized tests, emit all events.
let isNonParameterizedTest = eventContext.test?.isParameterized == false
var isNonParameterizedTestFunction = false
if let test = eventContext.test, !test.isSuite {
isNonParameterizedTestFunction = !test.isParameterized
}

switch kind {
case .runStarted:
self = .runStarted
case .testStarted:
if isNonParameterizedTest {
if isNonParameterizedTestFunction {
return nil
}
self = .testStarted
case .testCaseStarted:
self = isNonParameterizedTest ? .testStarted : .testCaseStarted
self = isNonParameterizedTestFunction ? .testStarted : .testCaseStarted
case .issueRecorded:
self = .issueRecorded
case .valueAttached:
self = .valueAttached
case .testCaseEnded:
self = isNonParameterizedTest ? .testEnded : .testCaseEnded
self = isNonParameterizedTestFunction ? .testEnded : .testCaseEnded
case .testCaseCancelled:
self = isNonParameterizedTest ? .testCancelled : .testCaseCancelled
self = isNonParameterizedTestFunction ? .testCancelled : .testCaseCancelled
case .testEnded:
if isNonParameterizedTest {
if isNonParameterizedTestFunction {
return nil
}
self = .testEnded
case .testSkipped:
self = .testSkipped
case .testCancelled:
if isNonParameterizedTest {
if isNonParameterizedTestFunction {
return nil
}
self = .testCancelled
Expand Down
8 changes: 8 additions & 0 deletions Tests/TestingTests/ABI.EncodedTestTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,5 +96,13 @@

#expect(test.decodeIDComponents() == nil)
}

@Test func `Can encode an event for a test suite`() {
let test = Test(traits: [], sourceLocation: .__here(), containingTypeInfo: TypeInfo(describing: Int.self))
let event = Event(.testStarted, testID: test.id, testCaseID: nil)
let eventContext = Event.Context(test: test, testCase: nil, iteration: 1, configuration: nil)
let encodedEvent = ABI.EncodedEvent<ABI.CurrentVersion>(encoding: event, in: eventContext, messages: [])
#expect(encodedEvent != nil)
}
#endif
}
Loading