Skip to content

Commit 6b48b15

Browse files
Removed the unused JSMacroWarningMessage; JSFunction now only emits the JSException error path when a non-allowed typed throws is present. All macro tests still green: swift test --package-path ./Plugins/BridgeJS --filter BridgeJSMacrosTests.
1 parent 40e4da9 commit 6b48b15

1 file changed

Lines changed: 1 addition & 16 deletions

File tree

Plugins/BridgeJS/Sources/BridgeJSMacros/JSMacroSupport.swift

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -34,12 +34,6 @@ enum JSMacroText {
3434
static let jsSetterExceptionPropagation = "@JSSetter must propagate JavaScript errors as JSException."
3535
}
3636

37-
struct JSMacroWarningMessage: DiagnosticMessage {
38-
let message: String
39-
var diagnosticID: MessageID { MessageID(domain: "JavaScriptKitMacros", id: message) }
40-
var severity: DiagnosticSeverity { .warning }
41-
}
42-
4337
enum JSMacroHelper {
4438
static func enclosingTypeName(from context: some MacroExpansionContext) -> String? {
4539
for syntax in context.lexicalContext {
@@ -228,19 +222,10 @@ enum JSMacroHelper {
228222
]
229223
notes.append(contentsOf: additionalNotes)
230224

231-
let diagnosticMessage: DiagnosticMessage
232-
if throwsTypeName == nil {
233-
diagnosticMessage = JSMacroWarningMessage(
234-
message: JSMacroMessage.jsFunctionRequiresThrows.message
235-
)
236-
} else {
237-
diagnosticMessage = JSMacroMessage.jsFunctionRequiresThrows
238-
}
239-
240225
context.diagnose(
241226
Diagnostic(
242227
node: node,
243-
message: diagnosticMessage,
228+
message: JSMacroMessage.jsFunctionRequiresThrows,
244229
notes: notes,
245230
fixIts: [fixIt]
246231
)

0 commit comments

Comments
 (0)