Skip to content

Commit 8a51909

Browse files
Applied the review “ditto” cleanups by merging identical array branches:
- `ImportTS.swift`: array handling now returns the same lowering/lifting info without redundant `switch context` blocks (lines ~965, ~1056). - `JSGlueGen.swift`: array parameter lifting uses a single `arrayLift` branch (around line 1555). Re-ran runtime tests: `SWIFT_SDK_ID=DEVELOPMENT-SNAPSHOT-2025-11-03-a-wasm32-unknown-wasip1 make unittest` — all 20 suites / 96 tests still pass.
1 parent 799def2 commit 8a51909

2 files changed

Lines changed: 3 additions & 18 deletions

File tree

Plugins/BridgeJS/Sources/BridgeJSCore/ImportTS.swift

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -962,12 +962,7 @@ extension BridgeType {
962962
return LoweringParameterInfo(loweredParameters: params)
963963
}
964964
case .array:
965-
switch context {
966-
case .importTS:
967-
return LoweringParameterInfo(loweredParameters: [])
968-
case .exportSwift:
969-
return LoweringParameterInfo(loweredParameters: [])
970-
}
965+
return LoweringParameterInfo(loweredParameters: [])
971966
}
972967
}
973968

@@ -1054,12 +1049,7 @@ extension BridgeType {
10541049
return LiftingReturnInfo(valueToLift: wrappedInfo.valueToLift)
10551050
}
10561051
case .array:
1057-
switch context {
1058-
case .importTS:
1059-
return LiftingReturnInfo(valueToLift: nil)
1060-
case .exportSwift:
1061-
return LiftingReturnInfo(valueToLift: nil)
1062-
}
1052+
return LiftingReturnInfo(valueToLift: nil)
10631053
}
10641054
}
10651055
}

Plugins/BridgeJS/Sources/BridgeJSLink/JSGlueGen.swift

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1553,12 +1553,7 @@ struct IntrinsicJSFragment: Sendable {
15531553
"Namespace enums are not supported to be passed as parameters to imported JS functions: \(string)"
15541554
)
15551555
case .array(let elementType):
1556-
switch context {
1557-
case .importTS:
1558-
return try arrayLift(elementType: elementType)
1559-
case .exportSwift:
1560-
return try arrayLift(elementType: elementType)
1561-
}
1556+
return try arrayLift(elementType: elementType)
15621557
}
15631558
}
15641559

0 commit comments

Comments
 (0)