Skip to content

Commit 302d4e2

Browse files
authored
Merge pull request #2620 from switchifyapp/fix/pc-mouse-movement-size-placement-2619
Move PC mouse movement size below clicks
2 parents 7986c3c + 416b51d commit 302d4e2

2 files changed

Lines changed: 16 additions & 4 deletions

File tree

app/src/main/java/com/enaboapps/switchify/screens/pc/PcMouseCommandGrid.kt

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -207,13 +207,19 @@ fun PcMovementSizeSection(
207207
fun PcControlCommandGrid(
208208
enabled: Boolean,
209209
movementStep: Int,
210+
selectedSize: PcMouseMovementSize,
211+
onSizeSelected: (PcMouseMovementSize) -> Unit,
210212
onCommandSelected: (PcControlCommand, Boolean) -> Unit,
213+
sizeSelectorEnabled: Boolean = true,
211214
modifier: Modifier = Modifier
212215
) {
213216
PcControlCommandSections(
214217
enabled = enabled,
215218
movementStep = movementStep,
219+
selectedSize = selectedSize,
220+
onSizeSelected = onSizeSelected,
216221
onCommandSelected = onCommandSelected,
222+
sizeSelectorEnabled = sizeSelectorEnabled,
217223
modifier = modifier
218224
)
219225
}
@@ -222,7 +228,10 @@ fun PcControlCommandGrid(
222228
fun PcControlCommandSections(
223229
enabled: Boolean,
224230
movementStep: Int,
231+
selectedSize: PcMouseMovementSize,
232+
onSizeSelected: (PcMouseMovementSize) -> Unit,
225233
onCommandSelected: (PcControlCommand, Boolean) -> Unit,
234+
sizeSelectorEnabled: Boolean = true,
226235
modifier: Modifier = Modifier
227236
) {
228237
val specs = pcMouseCompactControlSpecs(movementStep)
@@ -249,6 +258,11 @@ fun PcControlCommandSections(
249258
)
250259
}
251260
}
261+
PcMovementSizeSection(
262+
selectedSize = selectedSize,
263+
onSizeSelected = onSizeSelected,
264+
enabled = sizeSelectorEnabled
265+
)
252266
Section(titleResId = R.string.pc_mouse_section_scroll) {
253267
Box(modifier = Modifier.padding(12.dp)) {
254268
PcCompactCommandGrid(

app/src/main/java/com/enaboapps/switchify/screens/pc/PcMouseControlActivity.kt

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -163,12 +163,10 @@ private fun PcMouseControlScreen(
163163
PcControlCommandGrid(
164164
enabled = surfaceEnabled,
165165
movementStep = uiState.movementStep,
166-
onCommandSelected = viewModel::sendMouseCommand
167-
)
168-
PcMovementSizeSection(
169166
selectedSize = uiState.selectedMovementSize,
170167
onSizeSelected = viewModel::selectMovementSize,
171-
enabled = !uiState.isBusy
168+
onCommandSelected = viewModel::sendMouseCommand,
169+
sizeSelectorEnabled = !uiState.isBusy
172170
)
173171
}
174172
PcControlSurface.Typing -> PcTypingControlScreen(

0 commit comments

Comments
 (0)