Release modifiers after shortcut letters

- Release active PC modifier toggles after a successful alphabet shortcut
- Send modifier-up commands in stable reverse modifier order
- Update ViewModel coverage for the temporary shortcut chord behavior

Auto-generated

Author: OwenMcGirr

app/src/main/java/com/enaboapps/switchify/screens/pc/PcMouseControlViewModel.kt

@@ -183,12 +183,18 @@ class PcMouseControlViewModel(
             return
         }
         val keys = modifiers.map { it.toShortcutKey() } + letter
-        sendNoAckCommand(PcControlCommand.KeyboardShortcut(keys)) {
-            it.copy(
-                isBusy = false,
-                busyCommand = null,
-                message = null
-            )
+        viewModelScope.launch {
+            when (sendNoAckCommandNow(PcControlCommand.KeyboardShortcut(keys)) {
+                it.copy(
+                    isBusy = false,
+                    busyCommand = null,
+                    message = null
+                )
+            }) {
+                PcCommandResult.Ack -> releaseActiveModifiersIfPossible()
+                is PcCommandResult.AuthFailed,
+                is PcCommandResult.Failed -> Unit
+            }
         }
     }
 
@@ -492,7 +498,7 @@ class PcMouseControlViewModel(
     }
 
     private fun releaseActiveModifiersIfPossible() {
-        val modifiers = _uiState.value.activeModifiers.toList()
+        val modifiers = orderedShortcutModifiers(_uiState.value.activeModifiers).asReversed()
         if (modifiers.isEmpty()) return
         _uiState.update { it.copy(activeModifiers = emptySet()) }
         val controller = serviceControllerProvider()

app/src/test/java/com/enaboapps/switchify/screens/pc/PcMouseControlViewModelTest.kt

@@ -1204,11 +1204,13 @@ class PcMouseControlViewModelTest {
                         PcKeyboardShortcutKey.Shift,
                         PcKeyboardShortcutKey.Z
                     )
-                )
+                ),
+                PcControlCommand.ModifierUp(PcKeyboardModifierKey.Shift),
+                PcControlCommand.ModifierUp(PcKeyboardModifierKey.Ctrl)
             ),
             connector.realtimeCommands
         )
-        assertEquals(setOf(PcKeyboardModifierKey.Shift, PcKeyboardModifierKey.Ctrl), viewModel.uiState.value.activeModifiers)
+        assertEquals(emptySet<PcKeyboardModifierKey>(), viewModel.uiState.value.activeModifiers)
         assertNull(viewModel.uiState.value.message)
     }