Menu: add titles to FavouriteApps, GesturePatterns, FingerMode (#2247)

These three menus passed a null menuId to BaseMenu, so the title
header introduced in #2236 was skipped entirely. Give each a stable
menuId constant and map it in MenuConstants.getTitleResource to an
existing string resource so the header renders. CustomGestureConfirmation
remains intentionally titleless (transient mid-gesture prompt).

No new strings, no UX behavior change beyond the title appearing.

Co-authored-by: Owen McGirr <o.a.mcgirr@gmail.com>

Author: enaboapps

app/src/main/java/com/enaboapps/switchify/service/menu/menus/favouriteapps/FavouriteAppsMenu.kt

@@ -2,6 +2,7 @@ package com.enaboapps.switchify.service.menu.menus.favouriteapps
 
 import com.enaboapps.switchify.service.core.SwitchifyAccessibilityService
 import com.enaboapps.switchify.service.menu.menus.BaseMenu
+import com.enaboapps.switchify.service.menu.structure.MenuConstants
 import com.enaboapps.switchify.service.utils.FavouriteAppsManager
 
 /**
@@ -12,6 +13,7 @@ class FavouriteAppsMenu(
 ) : BaseMenu(
     accessibilityService = accessibilityService,
     items = emptyList(),
+    menuId = MenuConstants.MenuIds.FAVOURITE_APPS_MENU,
     dynamicLoad = {
         val favouriteAppsManager = FavouriteAppsManager(accessibilityService)
         val apps = favouriteAppsManager.getFavouriteApps()

app/src/main/java/com/enaboapps/switchify/service/menu/menus/gestures/FingerModeMenu.kt

@@ -3,6 +3,7 @@ package com.enaboapps.switchify.service.menu.menus.gestures
 import com.enaboapps.switchify.service.core.SwitchifyAccessibilityService
 import com.enaboapps.switchify.service.menu.MenuItem
 import com.enaboapps.switchify.service.menu.menus.BaseMenu
+import com.enaboapps.switchify.service.menu.structure.MenuConstants
 import com.enaboapps.switchify.service.menu.structure.MenuStructureHolder
 
 /**
@@ -16,7 +17,11 @@ import com.enaboapps.switchify.service.menu.structure.MenuStructureHolder
  * immediate feedback when finger modes are changed.
  */
 class FingerModeMenu(accessibilityService: SwitchifyAccessibilityService) :
-    BaseMenu(accessibilityService, buildFingerModeMenuItems(accessibilityService)) {
+    BaseMenu(
+        accessibilityService,
+        buildFingerModeMenuItems(accessibilityService),
+        MenuConstants.MenuIds.FINGER_MODE_MENU
+    ) {
 
     companion object {
         private fun buildFingerModeMenuItems(accessibilityService: SwitchifyAccessibilityService): List<MenuItem> {

app/src/main/java/com/enaboapps/switchify/service/menu/menus/gestures/GesturePatternsMenu.kt

@@ -5,14 +5,15 @@ import com.enaboapps.switchify.service.core.SwitchifyAccessibilityService
 import com.enaboapps.switchify.service.gestures.patterns.store.GesturePatternStore
 import com.enaboapps.switchify.service.menu.MenuItem
 import com.enaboapps.switchify.service.menu.menus.BaseMenu
+import com.enaboapps.switchify.service.menu.structure.MenuConstants
 
 class GesturePatternsMenu(
     accessibilityService: SwitchifyAccessibilityService
 ) :
     BaseMenu(
         accessibilityService,
         buildGesturePatternsMenuItems(accessibilityService),
-        null,  // No menuId - this is a dynamic menu
+        MenuConstants.MenuIds.GESTURE_PATTERNS_MENU,
         { getGesturePatterns(accessibilityService) }
     ) {
 

app/src/main/java/com/enaboapps/switchify/service/menu/structure/MenuConstants.kt

@@ -23,6 +23,9 @@ object MenuConstants {
         const val MEDIA_CONTROL_MENU = "media_control_menu"
         const val EDIT_MENU = "edit_menu"
         const val SETTINGS_MENU = "settings_menu"
+        const val FAVOURITE_APPS_MENU = "favourite_apps_menu"
+        const val GESTURE_PATTERNS_MENU = "gesture_patterns_menu"
+        const val FINGER_MODE_MENU = "finger_mode_menu"
     }
 
     fun getTitleResource(menuId: String?): Int? = when (menuId) {
@@ -38,6 +41,9 @@ object MenuConstants {
         MenuIds.MEDIA_CONTROL_MENU -> R.string.menu_title_media_control
         MenuIds.EDIT_MENU -> R.string.menu_title_edit
         MenuIds.SETTINGS_MENU -> R.string.menu_title_settings
+        MenuIds.FAVOURITE_APPS_MENU -> R.string.menu_title_favourite_apps
+        MenuIds.GESTURE_PATTERNS_MENU -> R.string.gesture_patterns_title
+        MenuIds.FINGER_MODE_MENU -> R.string.menu_item_finger_mode
         else -> null
     }