Defer PC controller until device unlock (#2411)

- Move PC service connection controller creation out of direct boot startup
- Initialize PC control support with other unlock-protected service components
- Hide Control PC from the locked-boot service menu

?? Auto-generated

Co-authored-by: Owen McGirr <o.a.mcgirr@gmail.com>

Author: enaboapps

app/src/main/java/com/enaboapps/switchify/service/core/SwitchifyAccessibilityService.kt

@@ -101,7 +101,6 @@ class SwitchifyAccessibilityService : AccessibilityService(), LifecycleOwner,
         AudioActionManager.init(this)
 
         ServiceCore.init(this)
-        ServiceCore.setPcServiceConnectionController(PcServiceConnectionController(this, serviceScope))
 
         val scanningManager = ServiceCore.getScanningManager() ?: return
         val externalSwitchListener = ServiceCore.getExternalSwitchListener() ?: return
@@ -167,6 +166,7 @@ class SwitchifyAccessibilityService : AccessibilityService(), LifecycleOwner,
             IAPHandler.connect(context = this)
             // Evaluate camera state now that switches are loaded
             cameraManager.evaluateAndUpdateCameraState()
+            initPcServiceConnectionControllerIfNeeded()
             // Initialize StatsCollector now that device is unlocked and flush any queued events
             val statsCollector = StatsCollector.getInstance()
             statsCollector.ensureInitialized()
@@ -176,6 +176,11 @@ class SwitchifyAccessibilityService : AccessibilityService(), LifecycleOwner,
         }
     }
 
+    private fun initPcServiceConnectionControllerIfNeeded() {
+        if (ServiceCore.getPcServiceConnectionController() != null) return
+        ServiceCore.setPcServiceConnectionController(PcServiceConnectionController(this, serviceScope))
+    }
+
 
     /**
      * Setup callbacks for the camera service

app/src/main/java/com/enaboapps/switchify/service/menu/menus/main/MainMenuStructure.kt

@@ -145,13 +145,15 @@ class MainMenuStructure(
                     action = { MenuManager.getInstance().openMediaControlMenu() }
                 )
             },
-            MenuItemRegistry.getMainMenuDefinition("control_pc")?.let { def ->
-                MenuItem(
-                    definition = def,
-                    isLinkToMenu = true,
-                    action = { openPcControlActivity() }
-                )
-            },
+            if (deviceLockObserver.isUserUnlocked() == true) {
+                MenuItemRegistry.getMainMenuDefinition("control_pc")?.let { def ->
+                    MenuItem(
+                        definition = def,
+                        isLinkToMenu = true,
+                        action = { openPcControlActivity() }
+                    )
+                }
+            } else null,
             if (NodeExaminer.canPerformEditActions(GesturePoint.getPoint())) {
                 MenuItemRegistry.getMainMenuDefinition("edit")?.let { def ->
                     MenuItem(