Turn off Gesture Repeat for patterns (#2557)

- Disable Gesture Repeat silently before gesture pattern executors become active
- Clear active repeat sessions so pattern playback gestures cannot be captured for repeat
- Add targeted repeat and pattern manager coverage for silent disable behavior

🤖 Auto-generated

Co-authored-by: Owen McGirr <o.a.mcgirr@gmail.com>

Author: enaboapps

app/src/main/java/com/enaboapps/switchify/service/gestures/GestureRepeatManager.kt

@@ -155,6 +155,10 @@ class GestureRepeatManager private constructor() {
         clearServiceState(showMessage = false)
     }
 
+    internal fun turnAutoRepeatOffForGesturePatternStart() {
+        clearServiceState(showMessage = false)
+    }
+
     private fun getRepeatDelay(): Long {
         val delay = repeatDelayProviderForTesting?.invoke()
             ?: context?.let {

app/src/main/java/com/enaboapps/switchify/service/gestures/patterns/GesturePatternManager.kt

@@ -2,6 +2,7 @@ package com.enaboapps.switchify.service.gestures.patterns
 
 import android.content.Context
 import com.enaboapps.switchify.backend.preferences.PreferenceManager
+import com.enaboapps.switchify.service.gestures.GestureRepeatManager
 import java.util.concurrent.ConcurrentHashMap
 import java.util.concurrent.atomic.AtomicInteger
 
@@ -16,6 +17,7 @@ object GesturePatternManager {
     }
 
     fun registerExecutor(executor: GesturePatternExecutor) {
+        GestureRepeatManager.instance.turnAutoRepeatOffForGesturePatternStart()
         synchronized(lock) {
             val id = executorIdCounter.incrementAndGet()
             activeExecutors[id] = executor
@@ -82,4 +84,11 @@ object GesturePatternManager {
             return anyAdvanced
         }
     }
+
+    internal fun resetForTesting() {
+        synchronized(lock) {
+            activeExecutors.clear()
+            executorIdCounter.set(0)
+        }
+    }
 }

app/src/test/java/com/enaboapps/switchify/service/gestures/GestureRepeatManagerTest.kt

@@ -312,6 +312,33 @@ class GestureRepeatManagerTest {
         assertFalse(repeatManager.isRepeatSessionActive())
     }
 
+    @Test
+    fun turnAutoRepeatOffForGesturePatternStartClearsWaitingRepeatSilently() {
+        repeatManager.setAutoRepeatEnabledForTesting(true)
+        messages.clear()
+
+        repeatManager.turnAutoRepeatOffForGesturePatternStart()
+
+        assertFalse(repeatManager.isAutoRepeatEnabled())
+        assertFalse(repeatManager.isWaitingForGesture())
+        assertEquals(emptyList<Int>(), messages)
+    }
+
+    @Test
+    fun turnAutoRepeatOffForGesturePatternStartStopsActiveRepeatSilently() {
+        repeatManager.setAutoRepeatEnabledForTesting(true)
+        performGestureForRepeat()
+        messages.clear()
+
+        repeatManager.turnAutoRepeatOffForGesturePatternStart()
+
+        assertFalse(repeatManager.isAutoRepeatEnabled())
+        assertFalse(repeatManager.isRepeating())
+        assertFalse(repeatManager.isRepeatSessionActive())
+        assertNull(repeatManager.getRepeatedGestureDataForTesting())
+        assertEquals(emptyList<Int>(), messages)
+    }
+
     private fun performGestureForRepeat(): GestureData {
         val gestureData = testGesture()
         repeatManager.onGesturePerformed(gestureData)

app/src/test/java/com/enaboapps/switchify/service/gestures/patterns/GesturePatternManagerTest.kt

@@ -0,0 +1,100 @@
+package com.enaboapps.switchify.service.gestures.patterns
+
+import android.graphics.PointF
+import com.enaboapps.switchify.service.gestures.GestureRepeatManager
+import com.enaboapps.switchify.service.gestures.data.GestureData
+import com.enaboapps.switchify.service.gestures.data.GestureType
+import org.junit.After
+import org.junit.Assert.assertEquals
+import org.junit.Assert.assertFalse
+import org.junit.Assert.assertNull
+import org.junit.Assert.assertTrue
+import org.junit.Before
+import org.junit.Test
+import sun.misc.Unsafe
+
+class GesturePatternManagerTest {
+    private val repeatManager = GestureRepeatManager.instance
+    private val messages = mutableListOf<Int>()
+
+    @Before
+    fun setup() {
+        repeatManager.resetForTesting()
+        repeatManager.setSuppressHudForTesting(true)
+        repeatManager.setMessageRecorderForTesting { messages.add(it) }
+        messages.clear()
+        GesturePatternManager.resetForTesting()
+    }
+
+    @After
+    fun tearDown() {
+        repeatManager.resetForTesting()
+        GesturePatternManager.resetForTesting()
+    }
+
+    @Test
+    fun registerExecutorTurnsGestureRepeatOffWhenWaiting() {
+        repeatManager.setAutoRepeatEnabledForTesting(true)
+        val executor = testExecutor()
+
+        GesturePatternManager.registerExecutor(executor)
+
+        assertFalse(repeatManager.isAutoRepeatEnabled())
+        assertFalse(repeatManager.isWaitingForGesture())
+        assertEquals(emptyList<Int>(), messages)
+    }
+
+    @Test
+    fun registerExecutorStopsActiveGestureRepeat() {
+        repeatManager.setAutoRepeatEnabledForTesting(true)
+        repeatManager.onGesturePerformed(testGesture())
+        messages.clear()
+        val executor = testExecutor()
+
+        GesturePatternManager.registerExecutor(executor)
+
+        assertFalse(repeatManager.isAutoRepeatEnabled())
+        assertFalse(repeatManager.isRepeatSessionActive())
+        assertFalse(repeatManager.isRepeating())
+        assertNull(repeatManager.getRepeatedGestureDataForTesting())
+        assertEquals(emptyList<Int>(), messages)
+    }
+
+    @Test
+    fun unregisterExecutorDoesNotRestoreGestureRepeat() {
+        repeatManager.setAutoRepeatEnabledForTesting(true)
+        val executor = testExecutor()
+        GesturePatternManager.registerExecutor(executor)
+
+        GesturePatternManager.unregisterExecutor(executor)
+
+        assertFalse(repeatManager.isAutoRepeatEnabled())
+    }
+
+    @Test
+    fun registerExecutorKeepsPatternActive() {
+        val executor = testExecutor()
+
+        GesturePatternManager.registerExecutor(executor)
+
+        assertTrue(GesturePatternManager.isGesturePatternActive())
+
+        GesturePatternManager.unregisterExecutor(executor)
+
+        assertFalse(GesturePatternManager.isGesturePatternActive())
+    }
+
+    private fun testExecutor(): GesturePatternExecutor {
+        val unsafeField = Unsafe::class.java.getDeclaredField("theUnsafe")
+        unsafeField.isAccessible = true
+        val unsafe = unsafeField.get(null) as Unsafe
+        return unsafe.allocateInstance(GesturePatternExecutor::class.java) as GesturePatternExecutor
+    }
+
+    private fun testGesture(): GestureData {
+        return GestureData(
+            gestureType = GestureType.TAP,
+            startPoint = PointF(10f, 20f)
+        )
+    }
+}