Fix settings update progress binding (#322)

Co-authored-by: Owen McGirr <o.a.mcgirr@gmail.com>

Author: enaboapps

src/SwitchifyPc.App/SettingsWindow.xaml

@@ -543,10 +543,10 @@
                                                    Style="{StaticResource MutedText}" />
                                         <StackPanel Margin="0,10,0,0"
                                                     Visibility="{Binding IsUpdateDownloading, Converter={StaticResource BooleanToVisibilityConverter}}">
-                                            <ProgressBar Value="{Binding UpdateDownloadPercent}"
-                                                         IsIndeterminate="{Binding IsUpdateDownloadIndeterminate}" />
+                                            <ProgressBar Value="{Binding UpdateDownloadPercent, Mode=OneWay}"
+                                                         IsIndeterminate="{Binding IsUpdateDownloadIndeterminate, Mode=OneWay}" />
                                             <TextBlock Margin="0,6,0,0"
-                                                       Text="{Binding UpdateDownloadProgressText}"
+                                                       Text="{Binding UpdateDownloadProgressText, Mode=OneWay}"
                                                        Style="{StaticResource MutedText}" />
                                         </StackPanel>
                                         <WrapPanel Margin="0,14,0,0">

src/SwitchifyPc.Tests/SettingsWindowTests.cs

@@ -0,0 +1,59 @@
+using System.Threading;
+using SwitchifyPc.App;
+using SwitchifyPc.Core.Ui;
+using SwitchifyPc.Core.Updates;
+
+namespace SwitchifyPc.Tests;
+
+public sealed class SettingsWindowTests
+{
+    [Fact]
+    public void SettingsWindowLoadsWithUpdateDownloadProgress()
+    {
+        RunOnSta(() =>
+        {
+            SettingsViewModel viewModel = new();
+            viewModel.SetUpdateState(UpdateState.CreateInitial("0.2.4") with
+            {
+                Download = new UpdateDownloadProgress(
+                    UpdateDownloadStatus.Downloading,
+                    20_971_520,
+                    52_428_800,
+                    40)
+            });
+
+            SettingsWindow window = new(viewModel);
+            try
+            {
+                window.Show();
+                window.UpdateLayout();
+            }
+            finally
+            {
+                window.Close();
+            }
+        });
+    }
+
+    private static void RunOnSta(Action action)
+    {
+        Exception? exception = null;
+        Thread thread = new(() =>
+        {
+            try
+            {
+                action();
+            }
+            catch (Exception error)
+            {
+                exception = error;
+            }
+        });
+
+        thread.SetApartmentState(ApartmentState.STA);
+        thread.Start();
+        thread.Join();
+
+        if (exception is not null) throw exception;
+    }
+}

src/SwitchifyPc.Tests/SwitchifyPc.Tests.csproj

@@ -19,6 +19,7 @@
 
   <ItemGroup>
     <ProjectReference Include="..\SwitchifyPc.Core\SwitchifyPc.Core.csproj" />
+    <ProjectReference Include="..\SwitchifyPc.App\SwitchifyPc.App.csproj" />
     <ProjectReference Include="..\SwitchifyPc.Protocol\SwitchifyPc.Protocol.csproj" />
     <ProjectReference Include="..\SwitchifyPc.Windows\SwitchifyPc.Windows.csproj" />
   </ItemGroup>