Improve exception error information, fix request stringify.

Author: twose

src/Exception/BadResponseException.php

@@ -16,10 +16,9 @@ public function __construct(
         Request $request,
         ?Response $response,
         int $code = 0,
-        string $message = null,
+        string $message = 'Unknown Bad Response Error occurred!',
         \Exception $previous = null
     ) {
-        $message = $message ?: "Unknown Bad Response Error #{$code} occurred!";
         parent::__construct($request, $response, $code, $message, $previous);
     }
 }

src/Exception/ClientException.php

@@ -20,10 +20,12 @@ public function __construct(
         Request $request,
         ?Response $response,
         int $code = 0,
-        string $message = null,
+        string $message = 'Client side error, please check your configurations and permissions!',
         \Exception $previous = null
     ) {
-        $message = $message ?: "Client Error #{$code}: " . Status::getReasonPhrase($code) . '!';
+        if ($code === Status::NOT_FOUND) {
+            $message = "Your request uri {$request->getUri()} is wrong, please check it and try again!";
+        }
         parent::__construct($request, $response, $code, $message, $previous);
     }
 }

src/Exception/RequestException.php

@@ -26,7 +26,8 @@ public function __construct(
         \Exception $previous = null
     ) {
         $code = $code ? $code : ($response ? $response->getStatusCode() : 0);
-        parent::__construct($message, $code, $previous);
+        $phrase = $response->getReasonPhrase();
+        parent::__construct("HTTP {$code} {$phrase}: {$message}", $code, $previous);
         $this->request = $request;
         $this->response = $response;
     }

src/Exception/ServerException.php

@@ -20,11 +20,10 @@ public function __construct(
         Request $request,
         ?Response $response,
         int $code = 0,
-        string $message = null,
+        string $message = 'Server error occurred, please contact with the website service provider!',
         \Exception $previous = null
     )
     {
-        $message = $message ?: "Server Error #{$code}: " . Status::getReasonPhrase($code) . '!';
         parent::__construct($request, $response, $code, $message, $previous);
     }
 }

src/Exception/TooManyRedirectsException.php

@@ -23,7 +23,8 @@ public function __construct(
     ) {
         $this->redirect_headers = $redirects;
         $times = count($redirects);
-        $message = "Too many redirects! more than {$times} times!";
+        $location = $this->redirect_headers[$times - 1];
+        $message = "Too many redirects! more than {$times} times to {$location} !";
         parent::__construct($request, $response, $code, $message, $previous);
     }
 

src/Request.php

@@ -271,13 +271,13 @@ public function withUploadedFiles(array $uploadedFiles): self
 
     public function __toString()
     {
-        $req = trim($this->getMethod() . ' ' . $this->getRequestTarget()) . ' HTTP/' . $this->getProtocolVersion();
+        $req = trim("{$this->getMethod()} {$this->getRequestTarget()}") . " HTTP/{$this->getProtocolVersion()}\r\n";
         if (!$this->hasHeader('host')) {
-            $req .= "\r\nHost: " . $this->getUri()->getHost();
+            $req .= "Host: {$this->getUri()->getHost()}\r\n";
         }
-        $req .= $this->getHeadersString() . "\r\n\r\n" . $this->getBody();
+        $req .= "{$this->getHeadersString()}\r\n\r\n" . ($this->hasBody() ? $this->getBody() : '');
 
         return $req;
     }
 
-}
+}