udpate some logic for self update command

Author: inhere

app/Command/SelfUpdateCommand.php

@@ -17,18 +17,18 @@
 use function parse_url;
 
 /**
- * update the swoft-cli to latest version from github releases
+ * update the swoft-cli to latest version from github
  *
- * @Command("self-update", alias="selfupdate, upself, update-self, updateself", coroutine=true)
+ * @Command("self-update", alias="selfupdate, update-self, updateself", coroutine=true)
  */
 class SelfUpdateCommand
 {
     public const LATEST_RELEASE_URL = 'https://api.github.com/repos/swoft-cloud/swoft-cli/releases/latest';
 
     /**
-     * update the swoft-cli to latest version from github releases
+     * update the swoft-cli to latest version from github
      *
-     * @CommandMapping(alias="selfupdate, upself, update-self, updateself")
+     * @CommandMapping(alias="selfupdate, update-self, updateself")
      * @CommandOption(
      *     "only-check", type="bool",
      *     desc="only fetch latest release information, but dont download and update package",
@@ -47,30 +47,14 @@ public function up(Input $input, Output $output): void
 
         $output->colored('Fetch latest release information for Github ...', 'cyan');
 
-        $info = $this->parseUrl(self::LATEST_RELEASE_URL);
-        $port = (int)$info['port'];
-        $path = $info['path'];
-
-        $client = new Client($info['host'], $port, $port === 443);
-        $client->setHeaders([
-            'User-Agent' => 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/76.0.3809.132 Safari/537.36',
-        ]);
-        $client->execute($path);
-
-        // $status = $client->statusCode;
-        $result = $client->body;
-
-        // close connection
-        $client->close();
-
+        $result = $this->fetchInfo();
         $latest = json_decode($result, true);
         if (!$latest) {
-            Show::error('Failed for update swoft-cli: fetch latest version info failed');
+            Show::error('Failed for update: fetch latest version info failed');
             return;
         }
 
-        $tagName = $latest['tag_name'];
-
+        $tagName  = $latest['tag_name'];
         $metaInfo = [
             'local version'  => 'v' . SwoftCLI::VERSION,
             'latest version' => $tagName,
@@ -79,14 +63,13 @@ public function up(Input $input, Output $output): void
         ];
 
         Show::aList($metaInfo, 'latest release information');
-
         if ($input->getOpt('only-check')) {
             return;
         }
 
         // get phar download address.
         if (!isset($latest['assets'][0]['browser_download_url'])) {
-            Show::error('Failed for update swoft-cli: not found latest phar package download url');
+            Show::error('Failed for update: not found latest phar package download url');
             return;
         }
 
@@ -95,12 +78,33 @@ public function up(Input $input, Output $output): void
         Download::file($pharUrl);
     }
 
+    private function fetchInfo(): string
+    {
+        $info = $this->parseUrl(self::LATEST_RELEASE_URL);
+        $port = (int)$info['port'];
+        $path = $info['path'];
+
+        $client = new Client($info['host'], $port, $port === 443);
+        $client->setHeaders([
+            'User-Agent' => 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/76.0.3809.132 Safari/537.36',
+        ]);
+        $client->execute($path);
+
+        // $status = $client->statusCode;
+        $result = $client->body;
+
+        // close connection
+        $client->close();
+
+        return $result;
+    }
+
     /**
      * @param string $url
      *
      * @return array
      */
-    public function parseUrl(string $url): array
+    private function parseUrl(string $url): array
     {
         $info = parse_url($url);
 

app/bean.php

@@ -6,18 +6,17 @@
 
 return [
     'cliApp'     => [
-        'name'        => 'Swoft-cli',
+        'name'        => config('name'),
         'version'     => SwoftCLI::VERSION,
-        'description' => 'CLI tool application for quick use swoft framework',
+        'description' => config('description'),
     ],
     'cliRouter'     => [
         'idAliases' => [
             // 'run' => 'serve:run'
             'ab'          => 'tool:ab',
-            'upself'      => 'self-update:up',
             'update-self' => 'self-update:up',
             'updateself'  => 'self-update:up',
-            'selfupdate' => 'self-update:up',
+            'selfupdate'  => 'self-update:up',
             'self-update' => 'self-update:up',
         ],
         'disabledGroups' => ['http', 'asset'],

config/base.php

@@ -1,8 +1,10 @@
 <?php declare(strict_types=1);
 
+use Swoft\Cli\SwoftCLI;
+
 return [
-    'name'        => 'swoft cli',
-    'debug'       => env('SWOFT_DEBUG', 1),
-    'version'     => '1.0.0',
-    'description' => 'CLI tool application for quick use swoft',
+    'name'        => 'Swoft-cli',
+    'debug'       => env('SWOFT_DEBUG', 0),
+    'version'     => SwoftCLI::VERSION,
+    'description' => '🛠️ Command line tool application for quick use swoft',
 ];