Skip to content

Warn when SYMFONY_REQUIRE is set to an exact version constraint #1093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GromNaN wants to merge 2 commits into
base: 2.x
Choose a base branch
from
Open

Warn when SYMFONY_REQUIRE is set to an exact version constraint #1093

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b78505
Warn when SYMFONY_REQUIRE is set to an exact version constraint
GromNaN Jun 16, 2026
5e9be27
Use Composer Semver VersionParser to detect exact version constraint
GromNaN Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/Flex.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
use Composer\Plugin\PrePoolCreateEvent;
use Composer\Script\Event;
use Composer\Script\ScriptEvents;
use Composer\Semver\Constraint\Constraint;
use Composer\Semver\VersionParser;
use Symfony\Component\Console\Exception\ExceptionInterface as ConsoleExceptionInterface;
use Symfony\Component\Console\Input\ArgvInput;
Expand Down Expand Up @@ -219,7 +220,15 @@ class_exists(__NAMESPACE__.str_replace('/', '\\', substr($file, \strlen(__DIR__)
break;
}

$symfonyRequire = preg_replace('/\.x$/', '.x-dev', getenv('SYMFONY_REQUIRE') ?: ($composer->getPackage()->getExtra()['symfony']['require'] ?? ''));
$rawSymfonyRequire = getenv('SYMFONY_REQUIRE') ?: ($composer->getPackage()->getExtra()['symfony']['require'] ?? '');
$symfonyRequire = preg_replace('/\.x$/', '.x-dev', $rawSymfonyRequire);

if ($rawSymfonyRequire) {
$parsedConstraint = (new VersionParser())->parseConstraints($rawSymfonyRequire);
if ($parsedConstraint instanceof Constraint && '==' === $parsedConstraint->getOperator()) {
$io->writeError(\sprintf('<warning>SYMFONY_REQUIRE="%s" is an exact version constraint. Did you mean "%s.*" or "^%s"?</>', $rawSymfonyRequire, $rawSymfonyRequire, $rawSymfonyRequire));
}
}

if ($symfonyRequire || $this->ignorePreleases) {
$this->filter = new PackageFilter($io, $symfonyRequire, $this->downloader, $this->ignorePreleases);
Expand Down
41 changes: 41 additions & 0 deletions tests/FlexTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,47 @@ public function testPostInstall()
);
}

#[DataProvider('getSymfonyRequireConstraints')]
public function testSymfonyRequireExactVersionWarning(string $constraint, bool $expectWarning)
{
$io = new BufferIO('', OutputInterface::VERBOSITY_VERBOSE);

$package = $this->mockRootPackage();
$package->method('getRequires')->willReturn([new Link('dummy', 'symfony/flex', class_exists(MatchAllConstraint::class) ? new MatchAllConstraint() : null)]);

$composer = $this->mockComposer($this->mockLocker(), $package, Factory::createConfig($io));
if (version_compare('2.0.0', PluginInterface::PLUGIN_API_VERSION, '>')) {
$composer->setRepositoryManager($this->mockManager());
}

putenv('SYMFONY_REQUIRE='.$constraint);
try {
(new Flex())->activate($composer, $io);
} finally {
putenv('SYMFONY_REQUIRE');
}

if ($expectWarning) {
$this->assertStringContainsString(\sprintf('SYMFONY_REQUIRE="%s" is an exact version constraint', $constraint), $io->getOutput());
} else {
$this->assertStringNotContainsString('is an exact version constraint', $io->getOutput());
}
}

public static function getSymfonyRequireConstraints(): array
{
return [
'exact major' => ['7', true],
'exact minor' => ['7.4', true],
'exact patch' => ['7.4.1', true],
'caret' => ['^7.4', false],
'tilde' => ['~7.4', false],
'wildcard' => ['7.4.*', false],
'greater or equal' => ['>=7.4', false],
'x-range' => ['7.4.x', false],
];
}

public function testActivateLoadsClasses()
{
$io = new BufferIO('', OutputInterface::VERBOSITY_VERBOSE);
Expand Down
Loading