Skip to content

Commit 4f81981

Browse files
committed
minor #1747 Update CI after release of Symfony 7.4 and 8.0 (alexislefebvre)
This PR was squashed before being merged into the 1.x branch. Discussion ---------- Update CI after release of Symfony 7.4 and 8.0 It's very likely that composer used the stable versions after their release but let’s clean this up for consistency. Follow-up of: - GH-1724 Commits ------- 118f6f2 Update CI after release of Symfony 7.4 and 8.0
2 parents 08192e1 + 118f6f2 commit 4f81981

3 files changed

Lines changed: 4 additions & 12 deletions

File tree

.github/workflows/ci-linux.yaml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -53,14 +53,12 @@ jobs:
5353
symfony-version: '6.4.*'
5454
dependency-versions: 'lowest'
5555

56-
# unreleased Symfony 7.4
5756
- php-version: '8.2'
58-
symfony-version: '^7.4.0-RC2'
57+
symfony-version: '^7.4.0'
5958
dependency-versions: 'highest'
6059

61-
# unreleased Symfony 8.0
6260
- php-version: '8.4'
63-
symfony-version: '^8.0.0-RC2'
61+
symfony-version: '^8.0.0'
6462
dependency-versions: 'highest'
6563

6664
steps:

src/Security/Model/Authenticator.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
*
1717
* @internal
1818
*/
19-
final class Authenticator
19+
final class Authenticator implements \Stringable
2020
{
2121
public function __construct(
2222
public AuthenticatorType $type,

src/Test/MakerTestEnvironment.php

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -406,13 +406,7 @@ private function determineMissingDependencies(): array
406406

407407
public function getTargetSkeletonVersion(): ?string
408408
{
409-
$symfonyVersion = $_SERVER['SYMFONY_VERSION'] ?? '';
410-
411-
return match (true) {
412-
str_starts_with($symfonyVersion, '^7.4.') && str_contains($symfonyVersion, 'RC') => '7.4.x-dev',
413-
str_starts_with($symfonyVersion, '^8.0.') && str_contains($symfonyVersion, 'RC') => '8.0.x-dev',
414-
default => $symfonyVersion,
415-
};
409+
return $_SERVER['SYMFONY_VERSION'] ?? '';
416410
}
417411

418412
private function composerRequireMakerBundle(string $projectDirectory): void

0 commit comments

Comments
 (0)