Fix CS: Use static anonymous functions

Author: GromNaN

_docs_build/build.php

@@ -23,7 +23,7 @@
 (new Application('Symfony Docs Builder', '1.0'))
     ->register('build-docs')
     ->addOption('generate-fjson-files', null, InputOption::VALUE_NONE, 'Use this option to generate docs both in HTML and JSON formats')
-    ->setCode(function (InputInterface $input, OutputInterface $output) {
+    ->setCode(static function (InputInterface $input, OutputInterface $output) {
         $io = new SymfonyStyle($input, $output);
         $io->text('Building all Symfony Docs...');
 

src/Doctrine/EntityRelation.php

@@ -34,7 +34,7 @@ public function __construct(
         private string $inverseClass,
     ) {
         if (!\in_array($type, self::getValidRelationTypes())) {
-            throw new \Exception(\sprintf('Invalid relation type "%s"', $type));
+            throw new \Exception(\sprintf('Invalid relation type "%s".', $type));
         }
 
         if (self::ONE_TO_MANY === $type) {

src/Maker/MakeEntity.php

@@ -301,7 +301,7 @@ public function generate(InputInterface $input, ConsoleStyle $io, Generator $gen
                 }
                 $currentFields[] = $newFieldName;
             } else {
-                throw new \Exception('Invalid value');
+                throw new \Exception('Invalid value.');
             }
 
             foreach ($fileManagerOperations as $path => $manipulatorOrMessage) {
@@ -825,9 +825,9 @@ private function askRelationType(ConsoleStyle $io, string $entityClass, string $
             implode(', ', EntityRelation::getValidRelationTypes())
         ));
         $question->setAutocompleterValues(EntityRelation::getValidRelationTypes());
-        $question->setValidator(function ($type) {
+        $question->setValidator(static function ($type) {
             if (!\in_array($type, EntityRelation::getValidRelationTypes())) {
-                throw new \InvalidArgumentException(\sprintf('Invalid type: use one of: %s', implode(', ', EntityRelation::getValidRelationTypes())));
+                throw new \InvalidArgumentException(\sprintf('Invalid type, use one of: "%s"', implode('", "', EntityRelation::getValidRelationTypes())));
             }
 
             return $type;

src/Maker/MakeForm.php

@@ -67,7 +67,7 @@ public function interact(InputInterface $input, ConsoleStyle $io, Command $comma
             $entities = $this->entityHelper->getEntitiesForAutocomplete();
 
             $question = new Question($argument->getDescription());
-            $question->setValidator(fn ($answer) => Validator::existsOrNull($answer, $entities));
+            $question->setValidator(static fn ($answer) => Validator::existsOrNull($answer, $entities));
             $question->setAutocompleterValues($entities);
             $question->setMaxAttempts(3);
 

src/Maker/MakeListener.php

@@ -107,7 +107,7 @@ public function interact(InputInterface $input, ConsoleStyle $io, Command $comma
         $event = $input->getArgument('event');
         if (null === $this->getEventConstant($event) && null === $this->eventRegistry->getEventClassName($event)) {
             $eventList = $this->eventRegistry->getAllActiveEvents();
-            $eventFQCNList = array_filter(array_map($this->eventRegistry->getEventClassName(...), $eventList), fn ($eventFQCN) => \is_string($eventFQCN));
+            $eventFQCNList = array_filter(array_map($this->eventRegistry->getEventClassName(...), $eventList), static fn ($eventFQCN) => \is_string($eventFQCN));
             $eventIdAndFQCNList = array_unique(array_merge($eventList, $eventFQCNList));
             $suggestionList = [];
 

src/Maker/MakeStimulusController.php

@@ -159,7 +159,7 @@ public function generate(InputInterface $input, ConsoleStyle $io, Generator $gen
             \sprintf('- Open <info>%s</info> and add the code you need', $filePath),
             '- Use the controller in your templates:',
             ...array_map(
-                fn (string $line): string => "    $line",
+                static fn (string $line): string => "    $line",
                 explode("\n", $this->generateUsageExample($controllerName, $targetArgs, $valuesArg, $classesArgs)),
             ),
             'Find the documentation at <fg=yellow>https://symfony.com/bundles/StimulusBundle</>',
@@ -175,7 +175,7 @@ private function askForNextTarget(ConsoleStyle $io, array $targets, bool $isFirs
             $questionText = 'Add another target? Enter the target name (or press <return> to stop adding targets)';
         }
 
-        $targetName = $io->ask($questionText, validator: function (?string $name) use ($targets) {
+        $targetName = $io->ask($questionText, validator: static function (?string $name) use ($targets) {
             if (\in_array($name, $targets)) {
                 throw new \InvalidArgumentException(\sprintf('The "%s" target already exists.', $name));
             }
@@ -199,7 +199,7 @@ private function askForNextValue(ConsoleStyle $io, array $values, bool $isFirstV
             $questionText = 'Add another value? Enter the value name (or press <return> to stop adding values)';
         }
 
-        $valueName = $io->ask($questionText, null, function ($name) use ($values) {
+        $valueName = $io->ask($questionText, null, static function ($name) use ($values) {
             if (\array_key_exists($name, $values)) {
                 throw new \InvalidArgumentException(\sprintf('The "%s" value already exists.', $name));
             }
@@ -258,7 +258,7 @@ private function askForNextClass(ConsoleStyle $io, array $classes, bool $isFirst
             $questionText = 'Add another class? Enter the class name (or press <return> to stop adding classes)';
         }
 
-        $className = $io->ask($questionText, validator: function (?string $name) use ($classes) {
+        $className = $io->ask($questionText, validator: static function (?string $name) use ($classes) {
             if (str_contains($name, ' ')) {
                 throw new \InvalidArgumentException('Class name cannot contain spaces.');
             }
@@ -298,7 +298,7 @@ private function getValuesTypes(): array
      */
     private function generateUsageExample(string $name, array $targets, array $values, array $classes): string
     {
-        $slugify = fn (string $name) => str_replace('_', '-', Str::asSnakeCase($name));
+        $slugify = static fn (string $name) => str_replace('_', '-', Str::asSnakeCase($name));
         $controller = $slugify($name);
 
         $htmlTargets = [];

src/Renderer/FormTypeRenderer.php

@@ -43,7 +43,7 @@ public function render(ClassNameDetails $formClassDetails, array $formFields, ?C
                     $extraUseClasses = array_merge($extraUseClasses, $fieldTypeOptions['extra_use_classes'] ?? []);
                     $fieldTypeOptions['options_code'] = str_replace(
                         $fieldTypeOptions['extra_use_classes'],
-                        array_map(fn ($class) => Str::getShortClassName($class), $fieldTypeOptions['extra_use_classes']),
+                        array_map(static fn ($class) => Str::getShortClassName($class), $fieldTypeOptions['extra_use_classes']),
                         $fieldTypeOptions['options_code']
                     );
                 }

src/Test/MakerTestEnvironment.php

@@ -168,7 +168,7 @@ public function prepareDirectory(): void
                     ;
 
                     if (!$composerProcess->isSuccessful()) {
-                        throw new \Exception(\sprintf('Error running command: composer require %s -v. Output: "%s". Error: "%s"', implode(' ', $dependencies), $composerProcess->getOutput(), $composerProcess->getErrorOutput()));
+                        throw new \Exception(\sprintf('Error running command: composer require "%s" -v. Output: "%s". Error: "%s"', implode(' ', $dependencies), $composerProcess->getOutput(), $composerProcess->getErrorOutput()));
                     }
                 }
 
@@ -345,7 +345,7 @@ public function createInteractiveCommandProcess(string $commandName, array $user
             // start the command with some input
             $inputStream->write(current($userInputs)."\n");
 
-            $inputStream->onEmpty(function () use ($inputStream, &$userInputs) {
+            $inputStream->onEmpty(static function () use ($inputStream, &$userInputs) {
                 $nextInput = next($userInputs);
                 if (false === $nextInput) {
                     $inputStream->close();

src/Test/MakerTestRunner.php

@@ -114,7 +114,7 @@ public function modifyYamlFile(string $filename, \Closure $callback)
 
         $newData = $callback($manipulator->getData());
         if (!\is_array($newData)) {
-            throw new \Exception('The modifyYamlFile() callback must return the final array of data');
+            throw new \Exception('The modifyYamlFile() callback must return the final array of data.');
         }
         $manipulator->setData($newData);
 
@@ -172,7 +172,7 @@ public function configureDatabase(bool $createSchema = true): void
 
         // Flex includes a recipe to suffix the dbname w/ "_test" - lets keep
         // things simple for these tests and not do that.
-        $this->modifyYamlFile('config/packages/doctrine.yaml', function (array $config) {
+        $this->modifyYamlFile('config/packages/doctrine.yaml', static function (array $config) {
             if (isset($config['when@test']['doctrine']['dbal']['dbname_suffix'])) {
                 unset($config['when@test']['doctrine']['dbal']['dbname_suffix']);
             }

src/Util/ClassSourceManipulator.php

@@ -240,7 +240,7 @@ public function addTrait(string $trait): void
         $importedClassName = $this->addUseStatementIfNecessary($trait);
 
         /** @var Node\Stmt\TraitUse[] $traitNodes */
-        $traitNodes = $this->findAllNodes(fn ($node) => $node instanceof Node\Stmt\TraitUse);
+        $traitNodes = $this->findAllNodes(static fn ($node) => $node instanceof Node\Stmt\TraitUse);
 
         foreach ($traitNodes as $node) {
             if ($node->traits[0]->toString() === $importedClassName) {
@@ -433,7 +433,7 @@ private function addCustomGetter(string $propertyName, string $methodName, $retu
                     break;
                 default:
                     // implement other cases if/when the library needs them
-                    throw new \Exception('Not implemented');
+                    throw new \Exception('Not implemented.');
             }
         }
 
@@ -964,21 +964,21 @@ private function setSourceCode(string $sourceCode): void
 
     private function getClassNode(): Node\Stmt\Class_
     {
-        $node = $this->findFirstNode(fn ($node) => $node instanceof Node\Stmt\Class_);
+        $node = $this->findFirstNode(static fn ($node) => $node instanceof Node\Stmt\Class_);
 
         if (!$node) {
-            throw new \Exception('Could not find class node');
+            throw new \Exception('Could not find class node.');
         }
 
         return $node;
     }
 
     private function getNamespaceNode(): Node\Stmt\Namespace_
     {
-        $node = $this->findFirstNode(fn ($node) => $node instanceof Node\Stmt\Namespace_);
+        $node = $this->findFirstNode(static fn ($node) => $node instanceof Node\Stmt\Namespace_);
 
         if (!$node) {
-            throw new \Exception('Could not find namespace node');
+            throw new \Exception('Could not find namespace node.');
         }
 
         return $node;
@@ -1044,10 +1044,10 @@ private function createSingleLineCommentNode(string $comment, string $context):
         switch ($context) {
             case self::CONTEXT_OUTSIDE_CLASS:
                 // just not needed yet
-                throw new \Exception('not supported');
+                throw new \Exception('Not supported.');
             case self::CONTEXT_CLASS:
                 // just not needed yet
-                throw new \Exception('not supported');
+                throw new \Exception('Not supported.');
             case self::CONTEXT_CLASS_METHOD:
                 return BuilderHelpers::normalizeStmt(new Node\Expr\Variable(\sprintf('__COMMENT__VAR_%d', \count($this->pendingComments) - 1)));
             default:
@@ -1146,16 +1146,16 @@ private function addNodeAfterProperties(Node $newNode): void
         $classNode = $this->getClassNode();
 
         // try to add after last property
-        $targetNode = $this->findLastNode(fn ($node) => $node instanceof Node\Stmt\Property, [$classNode]);
+        $targetNode = $this->findLastNode(static fn ($node) => $node instanceof Node\Stmt\Property, [$classNode]);
 
         // otherwise, try to add after the last constant
         if (!$targetNode) {
-            $targetNode = $this->findLastNode(fn ($node) => $node instanceof Node\Stmt\ClassConst, [$classNode]);
+            $targetNode = $this->findLastNode(static fn ($node) => $node instanceof Node\Stmt\ClassConst, [$classNode]);
         }
 
         // otherwise, try to add after the last trait
         if (!$targetNode) {
-            $targetNode = $this->findLastNode(fn ($node) => $node instanceof Node\Stmt\TraitUse, [$classNode]);
+            $targetNode = $this->findLastNode(static fn ($node) => $node instanceof Node\Stmt\TraitUse, [$classNode]);
         }
 
         // add the new property after this node