Skip to content

use parser v5 for consistent Emulative constructor#1682

Merged
weaverryan merged 1 commit into
symfony:1.xfrom
weaverryan:parser-v5
Apr 25, 2025
Merged

use parser v5 for consistent Emulative constructor#1682
weaverryan merged 1 commit into
symfony:1.xfrom
weaverryan:parser-v5

Conversation

@weaverryan
Copy link
Copy Markdown
Contributor

Fixes #1680

No good reason to keep this flexibility

@kbond
Copy link
Copy Markdown
Member

kbond commented Apr 25, 2025

What do you think about dropping phpunit-simple and just requiring/using phpunit directly?

@weaverryan
Copy link
Copy Markdown
Contributor Author

What do you think about dropping phpunit-simple and just requiring/using phpunit directly?

I'm 👍 for that

@weaverryan weaverryan merged commit f7ee43d into symfony:1.x Apr 25, 2025
7 checks passed
@weaverryan weaverryan deleted the parser-v5 branch April 25, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PhpParser\Lexer\Emulative::__construct(): Argument #1 ($options) must be of type array, PhpParser\PhpVersion given

2 participants