Convert config from XML to PHP#1729
Closed
nicolas-grekas wants to merge 1 commit into
Closed
Conversation
nicolas-grekas
force-pushed
the
php-config
branch
from
ddf7c1c to
ad2a13d
Compare
Member
|
Thanks Nicolas. This change is indeed mandatory to make this bundle work with Symfony 8. However, given that in #1724 Hugo is working to make this bundle work in Symfony 8, let's close this PR in favor of the other one, which includes this and other changes. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP is nicer than XML and symfony/symfony#60568 might make this required at some point.