fix(maker): use named arguments for validator constraints#1762
Closed
ozhantr wants to merge 0 commit into
Closed
Conversation
ozhantr
deleted the
fix/maker-registration-form-validator-named-arguments
branch
ozhantr
restored the
fix/maker-registration-form-validator-named-arguments
branch
ozhantr
deleted the
fix/maker-registration-form-validator-named-arguments
branch
Member
|
Hi, I don't know what happened to your PR, there is no commit. I created #1767 for this issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Symfony 8 no longer supports passing an array of options to validator
constraints such as IsTrue, NotBlank, and Length.
This PR updates the make:registration-form generator to use named
arguments when generating these constraints, preventing runtime errors
in newly generated forms on Symfony 8.
BC impact
None. This change only affects generated code.
Tests
Existing MakerBundle tests
Manual verification with Symfony 8