PHPUnit 11 compatibility#1766
Merged
Merged
Conversation
stof
reviewed
Jan 9, 2026
GromNaN
force-pushed
the
phpunit-11
branch
4 times, most recently
from
886e9de to
9ef2746
Compare
GromNaN
commented
Jan 9, 2026
| use Symfony\Component\Process\Process; | ||
|
|
||
| /** | ||
| * @method static iterable<array{0: MakerTestDetails}> getTestDetails() |
Member
Author
There was a problem hiding this comment.
By removing the abstract method declaration, moved to a PHPDoc, I avoid the breaking change.
We have to be careful to not add the abstract static method declaration in 1.x, but only in 2.x.
GromNaN
force-pushed
the
phpunit-11
branch
2 times, most recently
from
0f32ecd to
e1260cb
Compare
stof
reviewed
Jan 14, 2026
GromNaN
force-pushed
the
phpunit-11
branch
3 times, most recently
from
2ac6adf to
6ea7eca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Making all the data providers static require to make many other methods static in the
testsdirectory.The main point is the
MakerTestCasethat is part of the API and is extended in other projects. Creating a new class is the only way to change abstract methods from non-static to static in a BC way.