Update phpt message assertion for v0.3.0 BC break#10
Merged
Conversation
The deepclone_hydrate.phpt test checked for 'mangled key' in the error raised when a mangled key appears inside a scoped array. The v0.3.0 BC break changed that message to point at DEEPCLONE_HYDRATE_MANGLED_VARS and $flags; 'mangled key' no longer appears in the text. Assert on the new constant name instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/deepclone_hydrate.phptasserted on the substring'mangled key'in theValueErrorraised when a mangled key appears inside a scoped array. The v0.3.0 BC-break rename ($scoped_vars+$mangled_vars→ single$vars+DEEPCLONE_HYDRATE_MANGLED_VARSflag) updated the message to point users at the new flag/arg; the old substring no longer matches.Post-tag CI catch — all platforms (Linux NTS/ZTS/i386/debug, macOS, Windows) flagged the same assertion. Switched the check to
'DEEPCLONE_HYDRATE_MANGLED_VARS'so it tracks the current message.Test plan