Skip to content

Move Symfony DI config from XML to PHP#251

Merged
Kocal merged 1 commit into
symfony:2.xfrom
dmaicher:xml_to_php
Oct 13, 2025
Merged

Move Symfony DI config from XML to PHP#251
Kocal merged 1 commit into
symfony:2.xfrom
dmaicher:xml_to_php

Conversation

@dmaicher

Copy link
Copy Markdown
Contributor

Fixes #250

@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Oct 11, 2025
@dmaicher dmaicher force-pushed the xml_to_php branch 2 times, most recently from 4f96057 to b43e66c Compare October 11, 2025 08:25
@dmaicher dmaicher changed the title Move Symfony CI config from XML to PHP Move Symfony DI config from XML to PHP Oct 11, 2025

@Kocal Kocal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of this 🙌🏻

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Oct 13, 2025
@Kocal

Kocal commented Oct 13, 2025

Copy link
Copy Markdown
Member

Thank you @dmaicher.

@Kocal Kocal merged commit a227377 into symfony:2.x Oct 13, 2025
15 checks passed
@dmaicher dmaicher deleted the xml_to_php branch October 13, 2025 20:00
@acrobat

acrobat commented Nov 30, 2025

Copy link
Copy Markdown
Contributor

@Kocal would it be possible to tag this change as this would remove the triggered deprecations on symfony 7.4 for this bundle. Thanks!

@Kocal

Kocal commented Nov 30, 2025

Copy link
Copy Markdown
Member

Oops, sure!

@Kocal

Kocal commented Nov 30, 2025

Copy link
Copy Markdown
Member

Tagged https://github.com/symfony/webpack-encore-bundle/releases/tag/v2.4.0

@acrobat

acrobat commented Nov 30, 2025

Copy link
Copy Markdown
Contributor

Thanks! 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Reviewed Has been reviewed by a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move service configuration from XML to php

4 participants