Problems with square source images in JIT 2.0.0

[animaux]

Apparently JIT 2 chokes on square images in Mode 4 if the output is square too:

If the source image is 800×800px:

…/image/4/400/400/img/bilder/filename.jpg.jpg

this render the invalid dimensions error, whereas

…/image/4/400/401/img/bilder/filename.jpg

works as expected.

Using the first recipe with non-square images works fine. Also all the other modes with the square.

[animaux]

When using the same settings in a recipe Symphony throws:

Symphony Fatal Error: No JIT filter was found for this request.

Not sure if this is a result of the error above or a different issue.

Reverting back to JIT 1.4.4 (including the .htaccess-rules) solves both issues. Which also leads me to the point that the rewrite rules in the readme should be updated to the current version in 2.0.0!

[nitriques]

Which also leads me to the point that the rewrite rules in the readme should be updated to the current version in 2.0.0!

Done in c7cd618

this render the invalid dimensions error, whereas

Done in 3d92d82

Would you mind testing against the integration branch to see if the "no filter found" error persists ?

Thanks!

[nitriques]

@brendo Would you mind reviewing 3d92d82 ? Thanks!

[animaux]

Sure, will try tomorrow!

[nitriques]

Thanks @animaux

[animaux]

Sorry to report: All above mentioned problems persist in integration.

[animaux]

Plus in mode 2 JIT seems to ignore the smaller value. Weird.

[nitriques]

Well I do not know what to do as I can't seem to reproduce the error anymore. I'll check the mode 2 ASAP.

[nitriques]

@animaux Can you please test the latest integration branch please ? Thanks!