Convert self:: to static:: to allow late binding

nitriques · nitriques · commit 0ce9bf0ebb03 · 2015-05-13T12:16:32.000-04:00
This fixes a bug in php 5.3 where the static method in a child class would not get called.
diff --git a/data-sources/datasource.remote.php b/data-sources/datasource.remote.php
@@ -805,7 +805,9 @@ public static function fetch($url, $format, $timeout)
             $ch->setopt('HTTPHEADER', array('Accept: ' . $accepts));
         }
 
-        self::prepareGateway($ch);
+        // use static here to allow late static binding
+        // see http://php.net/manual/en/language.oop5.late-static-bindings.php
+        static::prepareGateway($ch);
 
         return array(
             trim($ch->exec()),

Original file line number	Diff line number	Diff line change
`@@ -805,7 +805,9 @@ public static function fetch($url, $format, $timeout)`
`805`	`805`	`$ch->setopt('HTTPHEADER', array('Accept: ' . $accepts));`
`806`	`806`	`}`
`807`	`807`
`808`		`- self::prepareGateway($ch);`
	`808`	`+ // use static here to allow late static binding`
	`809`	`+ // see http://php.net/manual/en/language.oop5.late-static-bindings.php`
	`810`	`+ static::prepareGateway($ch);`
`809`	`811`
`810`	`812`	`return array(`
`811`	`813`	`trim($ch->exec()),`