Skip to content

Commit 91aa307

Browse files
authored
Register missing fixers in default set, enforce CS in CI, fix README (#82)
* Register missing fixers in default set, enforce CS in CI, fix README * Keep unit tests in code_analysis matrix
1 parent bd7c36a commit 91aa307

3 files changed

Lines changed: 9 additions & 5 deletions

File tree

.github/workflows/code_analysis.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ jobs:
3030

3131
-
3232
name: 'Coding Standard'
33-
run: composer fix-cs --ansi
33+
run: composer check-cs --ansi
3434

3535
-
3636
name: 'Tests'
@@ -44,7 +44,7 @@ jobs:
4444
runs-on: ubuntu-latest
4545

4646
steps:
47-
- uses: actions/checkout@v3
47+
- uses: actions/checkout@v4
4848

4949
# see https://github.com/shivammathur/setup-php
5050
- uses: shivammathur/setup-php@v2
@@ -53,7 +53,7 @@ jobs:
5353
coverage: none
5454

5555
# composer install cache - https://github.com/ramsey/composer-install
56-
- uses: "ramsey/composer-install@v2"
56+
- uses: "ramsey/composer-install@v3"
5757

5858
# Override code from symplify/coding-standard shipped with ECS
5959
- run: |

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ vendor/bin/ecs --fix
4040

4141
<br>
4242

43-
# 12 Rules to Keep Your Code Clean
43+
# 14 Rules to Keep Your Code Clean
4444

4545
## ArrayListItemNewlineFixer
4646

@@ -165,7 +165,7 @@ Remove docblock descriptions which duplicate their property name
165165

166166
Remove docblock descriptions which duplicate their method name
167167

168-
- class: [`Symplify\CodingStandard\Fixer\Annotation\RemoveRedundantDescriptionFixer`](../src/Fixer/Annotation/RemoveRedundantDescriptionFixer.php)
168+
- class: [`Symplify\CodingStandard\Fixer\Annotation\RemoveMethodNameDuplicateDescriptionFixer`](../src/Fixer/Annotation/RemoveMethodNameDuplicateDescriptionFixer.php)
169169

170170
```diff
171171
/**

config/symplify.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,13 @@
88
use Symplify\CodingStandard\Fixer\Annotation\RemovePropertyVariableNameDescriptionFixer;
99
use Symplify\CodingStandard\Fixer\ArrayNotation\ArrayListItemNewlineFixer;
1010
use Symplify\CodingStandard\Fixer\ArrayNotation\ArrayOpenerAndCloserNewlineFixer;
11+
use Symplify\CodingStandard\Fixer\ArrayNotation\StandaloneLineInMultilineArrayFixer;
1112
use Symplify\CodingStandard\Fixer\Commenting\ParamReturnAndVarTagMalformsFixer;
1213
use Symplify\CodingStandard\Fixer\Commenting\RemoveUselessDefaultCommentFixer;
1314
use Symplify\CodingStandard\Fixer\LineLength\LineLengthFixer;
1415
use Symplify\CodingStandard\Fixer\Spacing\MethodChainingNewlineFixer;
1516
use Symplify\CodingStandard\Fixer\Spacing\SpaceAfterCommaHereNowDocFixer;
17+
use Symplify\CodingStandard\Fixer\Spacing\StandaloneLineConstructorParamFixer;
1618
use Symplify\CodingStandard\Fixer\Spacing\StandaloneLinePromotedPropertyFixer;
1719
use Symplify\CodingStandard\Fixer\Strict\BlankLineAfterStrictTypesFixer;
1820
use Symplify\EasyCodingStandard\Config\ECSConfig;
@@ -29,7 +31,9 @@
2931
// arrays
3032
ArrayListItemNewlineFixer::class,
3133
ArrayOpenerAndCloserNewlineFixer::class,
34+
StandaloneLineInMultilineArrayFixer::class,
3235
StandaloneLinePromotedPropertyFixer::class,
36+
StandaloneLineConstructorParamFixer::class,
3337

3438
// newlines
3539
MethodChainingNewlineFixer::class,

0 commit comments

Comments
 (0)