Skip to content
This repository was archived by the owner on Jan 8, 2021. It is now read-only.

Strip whitespaces when checking if asset tag is banned #122

Open
Haeki wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Strip whitespaces when checking if asset tag is banned #122

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,11 +204,11 @@ def is_banned_asset_tag(text):
# Is asset tag in banned list?
text = text.lower()
banned_tags = [
"Default string", "NA", "N/A", "None", " none", "Null", "oem", "o.e.m",
"Default string", "NA", "N/A", "None", "Null", "oem", "o.e.m",
"to be filled by o.e.m.", "Unknown", " ", ""
]
banned_tags = [t.lower() for t in banned_tags]
if text in banned_tags:
if text.strip() in banned_tags:
result = True
# Does it exceed the max allowed length for NetBox asset tags?
elif len(text) > 50:
Expand Down