feat: specify source map format

Author: MikeRomaa

README.md

@@ -27,7 +27,8 @@ Mach also allows you to create nested instruments, enabling you to bundle MSFS A
 - `-m, --minify` minify bundle code
 - `-s, --skip-simulator-package` skips writing simulator package templates
 - `-t, --output-metafile` output `build_meta.json` file to bundles directory
-- `-u, --output-sourcemaps` append sourcemaps to the end of bundle files
+- `-p, --sourcemaps` generate inline sourcemaps
+- `-p, --sourcemaps [linked | external | inline | both]` generate sourcemaps (see https://esbuild.github.io/api/#sourcemap for details on options)
 - `-v, --verbose` output additional build information
 
 #### `mach build [options]`

index.ts

@@ -8,7 +8,7 @@
 import fs from "node:fs";
 import path from "node:path";
 import chalk from "chalk";
-import { Command } from "commander";
+import { Command, Option } from "commander";
 import dotenv from "dotenv";
 // @ts-ignore FIXME: remove the ignore when/if https://github.com/antitoxic/import-single-ts/pull/7 is merged
 import { importSingleTs } from "import-single-ts";
@@ -46,7 +46,11 @@ const commandWithOptions = (name: string) =>
         .option("-m, --minify", "minify bundle code")
         .option("-s, --skip-simulator-package", "skips writing simulator package templates")
         .option("-t, --output-metafile", "output `build_meta.json` file to bundles directory")
-        .option("-u, --output-sourcemaps", "append sourcemaps to the end of bundle files")
+        .addOption(
+            new Option("-p, --sourcemaps [type]", "generate sourcemaps")
+                .choices(["linked", "external", "inline", "both"])
+                .preset("inline"),
+        )
         .option("-v, --verbose", "output additional build information")
         .hook("preAction", async (_thisCommand, actionCommand) => {
             signale.info(`Welcome to ${chalk.cyanBright("Mach")}, v${version}`);

package-lock.json

@@ -1,6 +1,6 @@
 {
     "name": "@synaptic-simulations/mach",
-    "version": "1.3.0-rc3",
+    "version": "1.3.0-rc4",
     "description": "The last MSFS instrument bundler you'll ever need.",
     "main": "./dist/index.js",
     "types": "./dist/index.d.ts",

package.json

@@ -19,7 +19,7 @@ function getBuildOptions(args: MachArgs, instrument: Instrument): BuildOptions {
         target: "es2017",
         logLevel: "silent",
         logOverride: args.werror ? ESBUILD_ERRORS : undefined,
-        sourcemap: args.outputSourcemaps ? "inline" : undefined,
+        sourcemap: args.sourcemaps,
         minify: args.minify,
 
         ...args.config.esbuild,

src/esbuild.ts

@@ -91,8 +91,8 @@ export interface MachArgs {
     verbose?: boolean;
     /** Output `build_meta.json` file to bundle directory. */
     outputMetafile?: boolean;
-    /** Append JS source maps to end of bundles. */
-    outputSourcemaps?: boolean;
+    /** Generate source maps. */
+    sourcemaps?: "linked" | "external" | "inline" | "both";
     /** Skip writing simulator package files. */
     skipSimulatorPackage?: boolean;
 }
@@ -155,7 +155,7 @@ export const MachArgsSchema = z.object({
     minify: z.boolean().optional(),
     verbose: z.boolean().optional(),
     outputMetafile: z.boolean().optional(),
-    outputSourcemaps: z.boolean().optional(),
+    sourcemaps: z.enum(["linked", "external", "inline", "both"]).optional(),
     skipSimulatorPackage: z.boolean().optional(),
 });