Merge branch 'main' into perf/chart-control-optimizations

Author: SaiyathAliFathima

maui/src/Accordion/AccordionItemView.cs

@@ -71,9 +71,21 @@ internal bool CanCollapseItemOnSingleAndMultipleExpandMode()
 				return false;
 			}
 
-			var expandedItems = Accordion.Items.Where(x => x._accordionItemView != null && x._accordionItemView.IsExpanded).ToList();
+			var expandedCount = 0;
+			foreach (var item in Accordion.Items)
+			{
+				if (item._accordionItemView != null && item._accordionItemView.IsExpanded)
+				{
+					expandedCount++;
+					if (expandedCount > 1)
+					{
+						break;
+					}
+				}
+			}
+
 			return (Accordion.ExpandMode == AccordionExpandMode.Single ||
-					Accordion.ExpandMode == AccordionExpandMode.Multiple) && expandedItems.Count == 1;	
+					Accordion.ExpandMode == AccordionExpandMode.Multiple) && expandedCount == 1;	
         }
 
 		#endregion

maui/src/Accordion/SfAccordion.cs

@@ -540,8 +540,22 @@ internal void UpdateIsExpandValueBasedOnIndex(int index, bool isExpanded)
 		/// </summary>
 		internal void UpdateSelection()
 		{
-			var selectedItems = Items.Where(x => x._accordionItemView != null && x._accordionItemView.IsSelected).ToList();
-			if (selectedItems.Count == 1 && Items[selectedItems[0]._itemIndex] is AccordionItem items && items._accordionItemView is AccordionItemView accordionItem)
+			AccordionItem? selectedItem = null;
+			int selectedCount = 0;
+			foreach (var item in Items)
+			{
+				if (item._accordionItemView != null && item._accordionItemView.IsSelected)
+				{
+					selectedItem ??= item;
+					selectedCount++;
+					if (selectedCount > 1)
+					{
+						break;
+					}
+				}
+			}
+
+			if (selectedCount == 1 && selectedItem != null && Items[selectedItem._itemIndex] is AccordionItem accordionItemEntry && accordionItemEntry._accordionItemView is AccordionItemView accordionItem)
 			{
 				accordionItem.IsSelected = false;
 			}
@@ -560,7 +574,15 @@ internal void UpdateAccordionItemsBasedOnExpandModes(bool isExpandModeChanged)
 				return;
 			}
 
-			var expandedItems = Items.Where(x => x._accordionItemView != null && x._accordionItemView.IsExpanded).ToList();
+			var expandedItems = new List<AccordionItem>();
+			foreach (var item in Items)
+			{
+				if (item._accordionItemView != null && item._accordionItemView.IsExpanded)
+				{
+					expandedItems.Add(item);
+				}
+			}
+
 			switch (ExpandMode)
 			{
 				case AccordionExpandMode.Single:
@@ -1575,7 +1597,15 @@ void IKeyboardListener.OnPreviewKeyDown(Syncfusion.Maui.Toolkit.Internals.KeyEve
 		/// <param name="e">The <see cref="KeyEventArgs"/> containing the event data for the key that was pressed.</param>
 		void IKeyboardListener.OnKeyDown(KeyEventArgs e)
 		{
-			var selectedItem = Items.FirstOrDefault(x => x._accordionItemView != null && x._accordionItemView.IsSelected);
+			AccordionItem? selectedItem = null;
+			foreach (var item in Items)
+			{
+				if (item._accordionItemView != null && item._accordionItemView.IsSelected)
+				{
+					selectedItem = item;
+					break;
+				}
+			}
 			if (e.Key == KeyboardKey.Down || (e.Key == KeyboardKey.Tab && !e.IsShiftKeyPressed))
 			{
 				OnDownKeyPressed(selectedItem);

maui/src/BottomSheet/SfBottomSheet.cs

@@ -1574,14 +1574,10 @@ void UpdateContentAccessibility(VisualElement element, bool exclude)
         /// <param name="exclude">True to exclude from accessibility, false to include.</param>
 		void UpdateSingleElement(VisualElement visualChild,bool exclude)
 		{
-			if (!_originalAccessibilityProperties.ContainsKey(visualChild))
-			{
-				// Store original values only if not already stored
-				_originalAccessibilityProperties[visualChild] = (
-					SemanticProperties.GetDescription(visualChild),
-					SemanticProperties.GetHint(visualChild)
-				);
-			}
+			_originalAccessibilityProperties.TryAdd(visualChild, (
+				SemanticProperties.GetDescription(visualChild),
+				SemanticProperties.GetHint(visualChild)
+			));
 
 			if (exclude)
 			{
@@ -1619,10 +1615,9 @@ void UpdateSingleElement(VisualElement visualChild,bool exclude)
 			var nativeContent = Content?.Handler?.PlatformView as Android.Views.View;
 			if (nativeContent is Android.Views.View rootView)
 			{
-					if (Content != null && !_androidContentDescriptions.ContainsKey(Content))
+					if (Content != null)
 					{
-						_androidContentDescriptions[Content] =
-							rootView.ContentDescription;
+						_androidContentDescriptions.TryAdd(Content, rootView.ContentDescription);
 					}
 
 				if (exclude) // when you want to hide content

maui/src/Calendar/Helper/CalendarViewHelper.cs

@@ -2483,7 +2483,7 @@ internal static CalendarTextStyle GetOutOfRangeDatesTextStyle()
         internal static List<DateTime> GetCurrentMonthDates(List<DateTime> visibleDates)
         {
             int currentMonth = visibleDates[visibleDates.Count / 2].Month;
-            List<DateTime> currentMonthDates = new List<DateTime>();
+            List<DateTime> currentMonthDates = new List<DateTime>(visibleDates.Count);
             foreach (DateTime date in visibleDates)
             {
                 if (date.Month != currentMonth)

maui/src/Calendar/Model/EventArgs/ViewChangedEventArgs.cs

@@ -7,17 +7,23 @@ namespace Syncfusion.Maui.Toolkit.Calendar
     /// </summary>
     public class CalendarViewChangedEventArgs : EventArgs
     {
+        #region Fields
+
+        static readonly ReadOnlyCollection<DateTime> s_emptyDates = new List<DateTime>(0).AsReadOnly();
+
+        #endregion
+
         #region Properties
 
         /// <summary>
         /// Gets the visible dates that visible on current view.
         /// </summary>
-        public ReadOnlyCollection<DateTime> NewVisibleDates { get; internal set; } = new List<DateTime>().AsReadOnly();
+        public ReadOnlyCollection<DateTime> NewVisibleDates { get; internal set; } = s_emptyDates;
 
         /// <summary>
         /// Gets the visible dates that visible on previous view.
         /// </summary>
-        public ReadOnlyCollection<DateTime> OldVisibleDates { get; internal set; } = new List<DateTime>().AsReadOnly();
+        public ReadOnlyCollection<DateTime> OldVisibleDates { get; internal set; } = s_emptyDates;
 
         /// <summary>
         /// Gets the new calendar view.

maui/src/Calendar/Views/CalendarView/MonthView/MonthView.cs

@@ -880,6 +880,24 @@ internal void SetFocusOnViewChanged()
 
         #region Private Methods
 
+		/// <summary>
+		/// Finds the special date icon details for a given date using a loop to avoid delegate allocation.
+		/// </summary>
+		/// <param name="dateTime">The date to look up.</param>
+		/// <returns>The matching CalendarIconDetails or null.</returns>
+		CalendarIconDetails? GetSpecialDateIcon(DateTime dateTime)
+		{
+			for (int i = 0; i < _specialDates.Count; i++)
+			{
+				if (CalendarViewHelper.IsSameDate(_calendarViewInfo.View, _specialDates[i].Date, dateTime, _calendarViewInfo.Identifier))
+				{
+					return _specialDates[i];
+				}
+			}
+
+			return null;
+		}
+
         /// <summary>
         /// Method to find the range is present in current view or not.
         /// </summary>
@@ -1635,7 +1653,7 @@ void DrawMonthCells(ICanvas canvas, bool isRTL, float weekNumberWidth, float mon
                 // The current date is today date and not a range then need to considered the today text style.
                 bool isTodayDate = todayDate.Date.Equals(dateTime.Date);
                  //// Stores the special dates icon details for drawing.
-                CalendarIconDetails? calendarSpecialDayIconDetails = _specialDates.FirstOrDefault(details => CalendarViewHelper.IsSameDate(_calendarViewInfo.View, details.Date, dateTime, _calendarViewInfo.Identifier));
+                CalendarIconDetails? calendarSpecialDayIconDetails = GetSpecialDateIcon(dateTime);
                 CalendarTextStyle textStyle = GetMonthCellStyle(dateTime, isTodayDate, isLeadingAndTrailingDates, isBlackoutDate, isDisabledDate, _calendarViewInfo.ShowOutOfRangeDates, calendarSpecialDayIconDetails != null, ref fillColor, cellBackground, trailingLeadingDateBackground, weekendsBackground, todayBackground, disabledDatesBackground, specialDatesBackground, cultureCalendar);
                 //// If background color is not transparent then the background color for month cell is applied.
                 if (fillColor != Colors.Transparent)
@@ -3080,7 +3098,7 @@ private void OnDateSemanticsNodeClicked(SemanticsNode node)
 
                 string blackOutDate = CalendarViewHelper.IsDateInDateCollection(dateTime, _disabledDates) ? SfCalendarResources.GetLocalizedString("Blackout Date") : string.Empty;
                 string disabledDate = CalendarViewHelper.IsDisabledDate(dateTime, _calendarViewInfo.View, _calendarViewInfo.EnablePastDates, _calendarViewInfo.MinimumDate, _calendarViewInfo.MaximumDate, _calendarViewInfo.SelectionMode, _calendarViewInfo.RangeSelectionDirection, _selectedRange, _calendarViewInfo.AllowViewNavigation, _calendarViewInfo.Identifier) ? SfCalendarResources.GetLocalizedString("Disabled Date") : string.Empty;
-                CalendarIconDetails? calendarSpecialDayIconDetails = _specialDates.FirstOrDefault(details => CalendarViewHelper.IsSameDate(_calendarViewInfo.View, details.Date, dateTime, _calendarViewInfo.Identifier));
+                CalendarIconDetails? calendarSpecialDayIconDetails = GetSpecialDateIcon(dateTime);
                 string specialDate = calendarSpecialDayIconDetails == null ? string.Empty : SfCalendarResources.GetLocalizedString("Special Date");
                 string dateType = string.IsNullOrEmpty(specialDate) ? !string.IsNullOrEmpty(blackOutDate) ? blackOutDate : disabledDate : specialDate;
                 string dateText = isGregorianCalendar ? dateTime.ToString("dddd, dd/MMMM/yyyy") + dateType : dateTime.ToString("dddd, dd/MMMM/yyyy", cultureInfo) + dateType;

maui/src/Carousel/Handlers/CarouselHandler.Windows.cs

@@ -71,9 +71,10 @@ private static void MapSelectedIndex(CarouselHandler handler, ICarousel virtualV
 		{
 			if (virtualView.ItemsSource != null)
 			{
-				if (virtualView.SelectedIndex >= virtualView.ItemsSource.Count() && virtualView.ItemsSource.Any())
+				int itemCount = virtualView.ItemsSource.Count();
+				if (virtualView.SelectedIndex >= itemCount && itemCount > 0)
 				{
-					handler.PlatformView.SelectedIndex = virtualView.ItemsSource.Count() - 1;
+					handler.PlatformView.SelectedIndex = itemCount - 1;
 				}
 				else if (virtualView.SelectedIndex < 0)
 				{

maui/src/Carousel/Handlers/CarouselHandler.iOS.cs

@@ -74,9 +74,10 @@ private static void MapSelectedIndex(CarouselHandler handler, ICarousel virtualV
 
 			if (virtualView.ItemsSource != null)
 			{
-				if (virtualView.SelectedIndex >= virtualView.ItemsSource.Count() && virtualView.ItemsSource.Any())
+				int itemCount = virtualView.ItemsSource.Count();
+				if (virtualView.SelectedIndex >= itemCount && itemCount > 0)
 				{
-					handler.PlatformView.SelectedIndex = virtualView.ItemsSource.Count() - 1;
+					handler.PlatformView.SelectedIndex = itemCount - 1;
 				}
 				else
 				{

maui/src/Carousel/Platform/Android/PlatformCarousel.Android.cs

@@ -3480,9 +3480,10 @@ internal void UpdateSelectedIndex(ICarousel mauiView)
 		{
 			if (mauiView.ItemsSource != null)
 			{
-				if (mauiView.SelectedIndex >= mauiView.ItemsSource.Count() && mauiView.ItemsSource.Any())
+				int itemCount = mauiView.ItemsSource.Count();
+				if (mauiView.SelectedIndex >= itemCount && itemCount > 0)
 				{
-					SelectedIndex = mauiView.ItemsSource.Count() - 1;
+					SelectedIndex = itemCount - 1;
 				}
 				else if (mauiView.SelectedIndex < 0)
 				{

maui/src/Carousel/Platform/iOS/PlatformCarousel.iOS.cs

@@ -879,7 +879,12 @@ public bool IsEnabled
         void EnableOrDisableInteraction()
         {
             UserInteractionEnabled = IsInteractionEnable();
-            Subviews.ToList().ForEach(subView => subView.UserInteractionEnabled = IsInteractionEnable());
+            bool interactionEnabled = IsInteractionEnable();
+            foreach (var subView in Subviews)
+            {
+                subView.UserInteractionEnabled = interactionEnabled;
+            }
+
             OnEnableInteractionPropertyChanged();
         }