Update the NumberPad key handling in SfOtpInput Control on Windows#397
Merged
Conversation
naveenkumar-sanjeevirayan
approved these changes
Jun 29, 2026
naveenkumar-sanjeevirayan
changed the title
naveenkumar-sanjeevirayan
changed the title
PaulAndersonS
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root Cause of the Issue
On Windows, keyboard input handling differentiates between top-row number keys (VirtualKey.Number0–Number9) and numeric keypad keys (VirtualKey.NumberPad0–NumberPad9).
The existing OnKeyDown logic handled only the top-row number keys and did not include NumberPad keys. As a result, inputs from the numeric keypad were ignored, preventing text updates and the triggering of the TextChanged event.
Description of Change
Updated the Windows OnKeyDown event handling logic to include numeric keypad inputs by adding a condition for VirtualKey.NumberPad0–NumberPad9.
This ensures both top-row numbers and NumberPad inputs are processed correctly and passed to the input handling logic.
Code change:
|| (e.Key >= Windows.System.VirtualKey.NumberPad0 && e.Key <= Windows.System.VirtualKey.NumberPad9)Screenshots
Before:
After: