fix(sdk): stop phantom undo snapshots from NodeProperties onChange (#18)

Author: piotrblaszczyk

.changeset/node-properties-onchange-phantom-undo.md

@@ -0,0 +1,5 @@
+---
+'@workflowbuilder/sdk': patch
+---
+
+fix: stop `NodeProperties` from pushing a phantom undo entry when JsonForms re-emits `onChange` after an external `data` change (e.g. just after `undo()`), which previously cleared `future` and broke redo.

packages/sdk/src/features/properties-bar/components/node-properties/node-properties.tsx

@@ -5,6 +5,7 @@ import { isDeepEqual } from 'remeda';
 
 import { StatusType } from '../../../../node/common';
 import type { WorkflowBuilderNode } from '../../../../node/node-data';
+import type { BaseNodeProperties } from '../../../../node/node-schema';
 import { getStoreEdges, setStoreEdges } from '../../../../store/slices/diagram-slice/actions';
 import { useStore } from '../../../../store/store';
 import { filterOutEdgesBySourceHandles } from '../../../../utils/edges/filter-out-edges-by-source-handles';
@@ -74,14 +75,20 @@ export const NodeProperties = memo(({ node }: Props) => {
 
   const { schema, uischema } = nodeDefinition;
   const onChange: JsonFormsReactProps['onChange'] = ({ data, errors }) => {
-    const flattenErrors = flatErrors(errors);
-
-    if (!isDeepEqual({ ...data, errors: flattenErrors }, properties)) {
-      trackFutureChange('dataUpdate');
-      setNodeProperties(id, { ...data, errors: flattenErrors });
-
-      removeEdgesForDeletedHandles(properties, data);
+    // JsonForms also fires onChange when its `data` prop changes externally
+    // (e.g. after undo) — not only on user edits. Ignore the derived `errors`
+    // field when checking for a real edit; otherwise we'd push a phantom
+    // snapshot that breaks undo/redo.
+    const { errors: _newErrors, ...dataWithoutErrors } = (data ?? {}) as BaseNodeProperties;
+    const { errors: _previousErrors, ...propertiesWithoutErrors } = properties;
+    if (isDeepEqual(dataWithoutErrors, propertiesWithoutErrors)) {
+      return;
     }
+
+    const flattenErrors = flatErrors(errors);
+    trackFutureChange('dataUpdate');
+    setNodeProperties(id, { ...data, errors: flattenErrors });
+    removeEdgesForDeletedHandles(properties, data);
   };
 
   return (