Skip to content

fix: Cut and paste are now blocked in read-only mode (WB-345) #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
szymon-t-sc wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Cut and paste are now blocked in read-only mode (WB-345) #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/readonly-cut-paste-block.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@workflowbuilder/sdk': patch
---

We are blocking cut and paste actions in the diagram in read-only mode; copying is still allowed.
14 changes: 12 additions & 2 deletions apps/demo/src/app/plugins/copy-paste/providers/copy-paste-provider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import {
getStoreSelection,
resetStoreSelection,
trackFutureChange,
useStore,
} from '@workflowbuilder/sdk';
import { useReactFlow } from '@xyflow/react';
import { type ReactNode, useCallback } from 'react';
Expand All @@ -27,6 +28,7 @@ const getHandleIdForCopyPaste: GetHandleId = (params) => {
};

function CopyPasteProviderComponent({ children }: CopyPasteProviderProps) {
const isReadOnlyMode = useStore((store) => store.isReadOnlyMode);
const mousePosition = useFlowMousePosition();

const { setNodes, setEdges } = useReactFlow();
Expand All @@ -44,22 +46,30 @@ function CopyPasteProviderComponent({ children }: CopyPasteProviderProps) {
});

const handleCut = useCallback(() => {
if (isReadOnlyMode) {
return;
}

const selection = getStoreSelection();

if (selection) {
trackFutureChange('cut');
cut();
}
}, [cut]);
}, [cut, isReadOnlyMode]);

const handlePaste = useCallback(async () => {
if (isReadOnlyMode) {
return;
}

const text = await navigator.clipboard.readText();

if (text) {
trackFutureChange('paste');
paste({ mousePosition: mousePosition.flow });
}
}, [mousePosition.flow, paste]);
}, [isReadOnlyMode, mousePosition.flow, paste]);

useCopyPasteKeyboardHandler({
handleCut,
Expand Down
Loading