refactor: rename foreground state class

Author: jvsena42

app/src/main/java/to/bitkit/androidServices/LightningNodeService.kt

@@ -35,7 +35,7 @@ import to.bitkit.models.NewTransactionSheetDetails
 import to.bitkit.models.NotificationDetails
 import to.bitkit.repositories.LightningRepo
 import to.bitkit.repositories.WalletRepo
-import to.bitkit.services.NodeServiceState
+import to.bitkit.services.NodeServiceFgState
 import to.bitkit.ui.ID_NOTIFICATION_NODE
 import to.bitkit.ui.MainActivity
 import to.bitkit.ui.pushNotification
@@ -76,7 +76,7 @@ class LightningNodeService : Service() {
     lateinit var appWidgetRefreshScheduler: AppWidgetRefreshScheduler
 
     @Inject
-    lateinit var nodeServiceState: NodeServiceState
+    lateinit var nodeServiceFgState: NodeServiceFgState
 
     private var hasStartedNode = false
 
@@ -195,7 +195,7 @@ class LightningNodeService : Service() {
             }
 
             ACTION_START_SERVICE -> if (promoteToForeground(startId)) {
-                nodeServiceState.setForegroundServiceRunning(true)
+                nodeServiceFgState.setForegroundServiceRunning(true)
                 setupService()
             }
             else -> stop(startId) { Logger.warn("Stopped service for unsupported action '$action'", context = TAG) }
@@ -237,7 +237,7 @@ class LightningNodeService : Service() {
 
     override fun onDestroy() {
         Logger.debug("onDestroy", context = TAG)
-        nodeServiceState.setForegroundServiceRunning(false)
+        nodeServiceFgState.setForegroundServiceRunning(false)
         // Safe to call even if already stopped — guarded by lifecycleMutex + isStoppedOrStopping()
         serviceScope.launch { lightningRepo.stop() }
         super.onDestroy()

app/src/main/java/to/bitkit/fcm/WakeNodeWorker.kt

@@ -37,7 +37,7 @@ import to.bitkit.models.msatCeilOf
 import to.bitkit.repositories.ActivityRepo
 import to.bitkit.repositories.BlocktankRepo
 import to.bitkit.repositories.LightningRepo
-import to.bitkit.services.NodeServiceState
+import to.bitkit.services.NodeServiceFgState
 import to.bitkit.ui.pushNotification
 import to.bitkit.utils.Logger
 import to.bitkit.utils.measured
@@ -54,7 +54,7 @@ class WakeNodeWorker @AssistedInject constructor(
     private val activityRepo: ActivityRepo,
     private val cacheStore: CacheStore,
     private val receivedNotificationContent: ReceivedNotificationContent,
-    private val nodeServiceState: NodeServiceState,
+    private val nodeServiceFgState: NodeServiceFgState,
 ) : CoroutineWorker(appContext, workerParams) {
     private var bestAttemptContent: NotificationDetails? = null
 
@@ -269,7 +269,7 @@ class WakeNodeWorker @AssistedInject constructor(
     }
 
     private fun isHandledInProcess(): Boolean =
-        App.currentActivity?.value != null || nodeServiceState.isForegroundServiceRunning
+        App.currentActivity?.value != null || nodeServiceFgState.isForegroundServiceRunning
 
     private suspend fun deliver() {
         // Send notification first

…a/to/bitkit/services/NodeServiceState.kt …to/bitkit/services/NodeServiceFgState.ktapp/src/main/java/to/bitkit/services/NodeServiceState.kt renamed to app/src/main/java/to/bitkit/services/NodeServiceFgState.kt app/src/main/java/to/bitkit/services/NodeServiceState.kt renamed to app/src/main/java/to/bitkit/services/NodeServiceFgState.kt

@@ -10,7 +10,7 @@ import javax.inject.Singleton
  * instead of posting its own (duplicate) notification.
  */
 @Singleton
-class NodeServiceState @Inject constructor() {
+class NodeServiceFgState @Inject constructor() {
     @Volatile
     var isForegroundServiceRunning = false
         private set

app/src/test/java/to/bitkit/fcm/WakeNodeWorkerTest.kt

@@ -41,7 +41,7 @@ import to.bitkit.repositories.ActivityRepo
 import to.bitkit.repositories.BlocktankRepo
 import to.bitkit.repositories.LightningRepo
 import to.bitkit.services.NodeEventHandler
-import to.bitkit.services.NodeServiceState
+import to.bitkit.services.NodeServiceFgState
 import to.bitkit.test.BaseUnitTest
 import kotlin.test.assertEquals
 import kotlin.test.assertNotNull
@@ -57,7 +57,7 @@ class WakeNodeWorkerTest : BaseUnitTest() {
     private val activityRepo = mock<ActivityRepo>()
     private val cacheStore = mock<CacheStore>()
     private val receivedNotificationContent = mock<ReceivedNotificationContent>()
-    private val nodeServiceState = NodeServiceState()
+    private val nodeServiceFgState = NodeServiceFgState()
 
     private val channelId = "channel-1"
     private val receivedTitle by lazy { context.getString(R.string.notification__received__title) }
@@ -71,7 +71,7 @@ class WakeNodeWorkerTest : BaseUnitTest() {
         val app = context as Application
         Shadows.shadowOf(app).grantPermissions(Manifest.permission.POST_NOTIFICATIONS)
 
-        // Default: app killed (no foreground activity); nodeServiceState defaults to not-running
+        // Default: app killed (no foreground activity); nodeServiceFgState defaults to not-running
         App.currentActivity = CurrentActivity()
     }
 
@@ -113,7 +113,7 @@ class WakeNodeWorkerTest : BaseUnitTest() {
 
     @Test
     fun `cjit channel ready skips notification when foreground service is running`() = test {
-        nodeServiceState.setForegroundServiceRunning(true)
+        nodeServiceFgState.setForegroundServiceRunning(true)
         val channel = cjitChannel(sats = 48_064)
         stubChannel(channel, cjitEntry = IcJitEntry.mock())
         stubStartFiring(channelReadyEvent())
@@ -178,7 +178,7 @@ class WakeNodeWorkerTest : BaseUnitTest() {
 
     @Test
     fun `payment received skips notification when foreground service is running`() = test {
-        nodeServiceState.setForegroundServiceRunning(true)
+        nodeServiceFgState.setForegroundServiceRunning(true)
         whenever(workerParams.inputData).thenReturn(
             workDataOf("type" to BlocktankNotificationType.incomingHtlc.name),
         )
@@ -204,7 +204,7 @@ class WakeNodeWorkerTest : BaseUnitTest() {
         activityRepo = activityRepo,
         cacheStore = cacheStore,
         receivedNotificationContent = receivedNotificationContent,
-        nodeServiceState = nodeServiceState,
+        nodeServiceFgState = nodeServiceFgState,
     )
 
     private fun channelReadyEvent() = mock<Event.ChannelReady> {