fix: preserve pubky session

Author: ben-kaufman

app/src/main/java/to/bitkit/repositories/PubkyRepo.kt

@@ -206,9 +206,7 @@ class PubkyRepo @Inject constructor(
     ): InitResult = withContext(ioDispatcher) {
         if (storedSecretKeyHex.isNullOrEmpty()) {
             if (!savedSessionSecret.isNullOrEmpty()) {
-                Logger.warn("Skipped re-sign-in recovery, no secret key available", context = TAG)
-                runCatching { keychain.delete(Keychain.Key.PAYKIT_SESSION.name) }
-                notifyBackupStateChanged()
+                Logger.warn("Skipped re-sign-in recovery, keeping saved session", context = TAG)
                 InitResult.RestorationFailed
             } else {
                 InitResult.NoSession
@@ -223,8 +221,6 @@ class PubkyRepo @Inject constructor(
                 InitResult.Restored(publicKey)
             }.getOrElse {
                 Logger.error("Failed re-sign-in recovery", it, context = TAG)
-                runCatching { keychain.delete(Keychain.Key.PAYKIT_SESSION.name) }
-                notifyBackupStateChanged()
                 InitResult.RestorationFailed
             }
         }

app/src/test/java/to/bitkit/repositories/PubkyRepoTest.kt

@@ -465,7 +465,7 @@ class PubkyRepoTest : BaseUnitTest() {
     }
 
     @Test
-    fun `initialize should delete stale saved session when re-sign-in is unavailable`() = test {
+    fun `initialize should keep saved session when re-sign-in is unavailable`() = test {
         val session = "stale_session"
         whenever(keychain.loadString(Keychain.Key.PAYKIT_SESSION.name)).thenReturn(session)
         whenever(keychain.loadString(Keychain.Key.PUBKY_SECRET_KEY.name)).thenReturn(null)
@@ -475,7 +475,7 @@ class PubkyRepoTest : BaseUnitTest() {
 
         assertTrue(sut.sessionRestorationFailed.value)
         assertFalse(sut.isAuthenticated.value)
-        verifyBlocking(keychain) { delete(Keychain.Key.PAYKIT_SESSION.name) }
+        verifyBlocking(keychain, never()) { delete(Keychain.Key.PAYKIT_SESSION.name) }
     }
 
     @Test